perf: return early from in_external_macro for root contexts - #161258
Merged
rust-bors[bot] merged 1 commit intoAug 18, 2026
Conversation
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 18, 2026
…-fast-path, r=petrochenkov perf: return early from in_external_macro for root contexts This line was hot when profiling clippy-driver. With this change, clippy instructions reduce for ryu -1.01%, syn -0.21%, regex -0.20%. r? @petrochenkov
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 18, 2026
…-fast-path, r=petrochenkov perf: return early from in_external_macro for root contexts This line was hot when profiling clippy-driver. With this change, clippy instructions reduce for ryu -1.01%, syn -0.21%, regex -0.20%. r? @petrochenkov
This was referenced Aug 18, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
…uwer Rollup of 11 pull requests Successful merges: - #161024 (resolving cyclic glob vis-max) - #161231 (passes: `rustc_scalable_vector` fields are not dead) - #161238 (remove scalar size mismatch interpreter error, make it an ICE instead) - #160345 (Resolver: add `checked` methods for `Cm(Ref)Cell`) - #161129 (Avoid ICE when recovering parenthesized type parameters) - #161235 (Compute job time in post-merge-report from the actual GitHub duration) - #161239 (Fix `#[repr(transparent)]` wrapper types not working with `Complex<T>`) - #161244 (Add regression test for indexing an unsized static without a body) - #161257 (Ignore target feature test when LLVM fails to compile minicore) - #161258 (perf: return early from in_external_macro for root contexts) - #161278 (Add regression test for normalization failure on erased closure in async block)
Member
|
@bors try @rust-timer queue profiles=check,clippy |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
… r=<try> perf: return early from in_external_macro for root contexts
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (68b3158): comparison URL. Overall result: no relevant changes - BENCHMARK(S) FAILEDBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression ❗ ❗ ❗ ❗ ❗
❗ ❗ ❗ ❗ ❗ Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesResults (secondary 3.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 455.347s -> 458.225s (0.63%) |
rustbot
removed
the
S-waiting-on-perf
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
Rollup merge of #161258 - xmakro:perf/in-external-macro-root-fast-path, r=petrochenkov perf: return early from in_external_macro for root contexts This line was hot when profiling clippy-driver. With this change, clippy instructions reduce for ryu -1.01%, syn -0.21%, regex -0.20%. r? @petrochenkov
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Aug 19, 2026
…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#161024 (resolving cyclic glob vis-max) - rust-lang/rust#161231 (passes: `rustc_scalable_vector` fields are not dead) - rust-lang/rust#161238 (remove scalar size mismatch interpreter error, make it an ICE instead) - rust-lang/rust#160345 (Resolver: add `checked` methods for `Cm(Ref)Cell`) - rust-lang/rust#161129 (Avoid ICE when recovering parenthesized type parameters) - rust-lang/rust#161235 (Compute job time in post-merge-report from the actual GitHub duration) - rust-lang/rust#161239 (Fix `#[repr(transparent)]` wrapper types not working with `Complex<T>`) - rust-lang/rust#161244 (Add regression test for indexing an unsized static without a body) - rust-lang/rust#161257 (Ignore target feature test when LLVM fails to compile minicore) - rust-lang/rust#161258 (perf: return early from in_external_macro for root contexts) - rust-lang/rust#161278 (Add regression test for normalization failure on erased closure in async block)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line was hot when profiling clippy-driver. With this change, clippy instructions reduce for ryu -1.01%, syn -0.21%, regex -0.20%.
r? @petrochenkov