Properly feature gate doc(rust_logo) by mejrs · Pull Request #164582 · rust-lang/rust

mejrs · 2026-10-19T13:31:44Z

View all comments

fixes #161984

It's a breaking change, technically. I didn't find it in the crater rollup, but will rerun just in case.

rustbot · 2026-10-19T13:31:48Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-10-19T13:31:52Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 17 candidates

mejrs · 2026-10-19T13:31:59Z

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-164148-crater-rollup/retry-regressed-list.txt p=1

craterbot · 2026-10-19T13:32:01Z

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

mejrs · 2026-10-19T13:32:18Z

@bors try

Properly feature gate doc(rust_logo)

JonathanBrouwer

r=me with lang approval

View changes since this review

mejrs · 2026-10-19T13:44:13Z

Is the doc attribute t-lang or t-rustdoc territory?

JonathanBrouwer · 2026-10-19T14:00:17Z

Oh right, yeah I think T-rustdoc should be fine? Not sure tbh probably better to ask them

rust-bors · 2026-10-19T14:32:11Z

☀️ Try build successful (CI)
Build commit: 04e9298 (04e9298c771dcc8a88d17c0257382c1e4ae3da97)
Base parent: b26b4e7 (b26b4e75de6aac63fc6beeecebad5b3a5f84d2a4)

mejrs · 2026-10-19T14:35:34Z

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-164148-crater-rollup/retry-regressed-list.txt p=1

craterbot · 2026-10-19T14:35:39Z

👌 Experiment pr-164582 created and queued.
🤖 Automatically detected try build 04e9298
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-10-20T13:01:04Z

🚧 Experiment pr-164582 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-10-21T01:04:03Z

🎉 Experiment pr-164582 is completed!
📊 0 regressed and 0 fixed (28882 total)
📊 1098 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-164582/retry-regressed-list.txt ↩

rust-rfcbot · 2026-11-10T21:10:26Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

GuillaumeGomez · 2026-11-10T21:11:43Z

@bors r=JonathanBrouwer,GuillaumeGomez

rust-bors · 2026-11-10T21:11:46Z

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-t-rustdoc.

GuillaumeGomez · 2026-11-10T21:12:18Z

@bors r=JonathanBrouwer,GuillaumeGomez

rust-bors · 2026-11-10T21:12:21Z

📌 Commit dfeb81d has been approved by JonathanBrouwer,GuillaumeGomez

It is now in the queue for this repository.

…aumeGomez Properly feature gate doc(rust_logo) fixes #161984 It's a breaking change, technically. I didn't find it in the crater rollup, but will rerun just in case.

rust-log-analyzer · 2026-11-11T02:09:39Z

The job test-various failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-11-11T02:10:11Z

💔 Test for 66a86c8 failed: CI. Failed job:

auto - test-various (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-11-11T05:44:40Z

@bors retry
@bors try jobs=test-various

Properly feature gate doc(rust_logo) try-job: test-various

…ouwer,GuillaumeGomez Properly feature gate doc(rust_logo) fixes rust-lang#161984 It's a breaking change, technically. I didn't find it in the crater rollup, but will rerun just in case.

Rollup of 2 pull requests Successful merges: - #164582 (Properly feature gate doc(rust_logo)) - #165797 (Disable flaky `tests/debuginfo/basic-stepping.rs` on aarch64 msvc)

rust-bors · 2026-11-11T07:40:43Z

☀️ Try build successful (CI)
Build commit: ae8d1a2 (ae8d1a260b344454c51d391c1841417c2c0a6cd6)
Base parent: 9c56488 (9c5648833e5ceb667a708d53c00b83ecc9e610d5)

…uwer Rollup of 8 pull requests Successful merges: - #165522 (Add relnotes for 1.100) - #158970 (Support underscore as associated const name in inherent impls) - #164582 (Properly feature gate doc(rust_logo)) - #165680 (Update call to llvm::codegen::InitTargetOptionsFromCodeGenFlags) - #165768 (Bail out ill-formed aliases when assembling trait object bounds candidates) - #165776 (docs: Fix a typo in rustc-dev-guide [NFC]) - #165797 (Disable flaky `tests/debuginfo/basic-stepping.rs` on aarch64 msvc) - #165798 (Add a regression test for fixed next-solver ICE)

Rollup merge of #164582 - mejrs:rust_logo_gate, r=JonathanBrouwer,GuillaumeGomez Properly feature gate doc(rust_logo) fixes #161984 It's a breaking change, technically. I didn't find it in the crater rollup, but will rerun just in case.

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 19, 2026

rustbot assigned fee1-dead Oct 19, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 19, 2026

Auto merge of #164582 - mejrs:rust_logo_gate, r=<try>

04e9298

Properly feature gate doc(rust_logo)

JonathanBrouwer approved these changes Oct 19, 2026

View reviewed changes

JonathanBrouwer assigned JonathanBrouwer and unassigned fee1-dead Oct 19, 2026

JonathanBrouwer added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2026

This comment has been minimized.

Sign in to view

bjorn3 reviewed Oct 19, 2026

View reviewed changes

Comment thread tests/ui/feature-gates/doc-rust-logo.rs Resolved

mejrs force-pushed the rust_logo_gate branch from 155c600 to 0f50980 Compare October 20, 2026 17:44

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 21, 2026

JonathanBrouwer added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. S-waiting-on-t-rustdoc Status: Awaiting decision from T-rustdoc labels Oct 21, 2026

rust-rfcbot added the to-announce Announce this issue on triage meeting label Nov 10, 2026

rustbot mentioned this pull request Nov 10, 2026

Tracking issue for release notes of #164582: Properly feature gate doc(rust_logo) #165781

Open

GuillaumeGomez removed the S-waiting-on-t-rustdoc Status: Awaiting decision from T-rustdoc label Nov 10, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 11, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Nov 11, 2026

Auto merge of #164582 - mejrs:rust_logo_gate, r=<try>

ae8d1a2

Properly feature gate doc(rust_logo) try-job: test-various

Zalathar mentioned this pull request Nov 11, 2026

Rollup of 2 pull requests #165799

Closed

JonathanBrouwer mentioned this pull request Nov 11, 2026

Rollup of 8 pull requests #165808

Merged

rust-bors Bot merged commit 914bd4b into rust-lang:main Nov 11, 2026
15 of 16 checks passed

rustbot added this to the 1.102.0 milestone Nov 11, 2026

Conversation

mejrs commented Oct 19, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 19, 2026

Uh oh!

rustbot commented Oct 19, 2026

Uh oh!

mejrs commented Oct 19, 2026

Uh oh!

craterbot commented Oct 19, 2026

Uh oh!

mejrs commented Oct 19, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mejrs commented Oct 19, 2026

Uh oh!

JonathanBrouwer commented Oct 19, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 19, 2026

Uh oh!

mejrs commented Oct 19, 2026

Uh oh!

craterbot commented Oct 19, 2026

Uh oh!

Uh oh!

craterbot commented Oct 20, 2026

Uh oh!

craterbot commented Oct 21, 2026

Footnotes

Uh oh!

rust-rfcbot commented Nov 10, 2026

Uh oh!

GuillaumeGomez commented Nov 10, 2026

Uh oh!

rust-bors Bot commented Nov 10, 2026

Uh oh!

GuillaumeGomez commented Nov 10, 2026

Uh oh!

rust-bors Bot commented Nov 10, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Nov 11, 2026

Uh oh!

rust-bors Bot commented Nov 11, 2026

Uh oh!

JonathanBrouwer commented Nov 11, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 11, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

mejrs commented Oct 19, 2026 •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading