Improve error message for incomplete toolchains#4819
Improve error message for incomplete toolchains#4819Inconnu08 wants to merge 1 commit intorust-lang:mainfrom
Conversation
| .with_stderr(str![[r#" | ||
| error: toolchain 'nightly-[HOST_TRIPLE]' appears to be incomplete | ||
| help: this may happen if the toolchain installation was interrupted | ||
| help: run `rustup toolchain install nightly-[HOST_TRIPLE]` to reinstall |
There was a problem hiding this comment.
Suggest adding an extra step to see if the suggestion really works.
There was a problem hiding this comment.
Edit: I tried verifying the suggested reinstall step.
In the test environment, rustup toolchain install nightly reports the toolchain as unchanged and does not repair the missing-manifest state.
However, when testing manually with a real dist server, I noticed that rustup component list --toolchain nightly actually triggers a re-sync and repairs the toolchain automatically.
So recovery currently depends on the command used, and toolchain install does not explicitly detect and repair incomplete states.
Given this, I think the current suggestion may be misleading, so I’m considering adjusting the help text to be less prescriptive and soften it.
Improve the error message shown when
rustupencounters a toolchain that is missing its manifest.Interrupted installations can leave a partially installed toolchain behind. Rustup already improves the recovery experience when reinstalling such toolchains (#4725), but users can still encounter a confusing "Missing manifest" error when interacting with the incomplete toolchain before retrying installation.
Related to #4724
Builds on the interrupted-install UX improvements from #4725