feat: skip detonation by default, fix rescan body and OS values - #26
Merged
Conversation
ayoubfaouzi
commented
Aug 3, 2026
ayoubfaouzi
commented
Member
- fix: deduplicate identical files extracted from archives
- Clarify that -d/--enableDetonation opts into sandbox detonation; skip_detonation=true is sent by default (help text said the opposite) - Flatten the rescan JSON body: the backend binds FileScanRequest directly, so os/timeout nested under scan_cfg were silently ignored - Use the platform's canonical OS identifier windows-10-x64 (was win-10, which the backend accepts but the web UI doesn't recognize)
The backend records every archive entry in derived_files but only scans each unique hash once. The CLI created one polling row per entry and, on rescan paths, submitted duplicate hashes twice. Dedupe children by SHA256 before rescanning/polling and show the duplicate count in the archive row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.