Skip to content

Fixed divide by zero issue in basic calculator #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shivam01code wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed divide by zero issue in basic calculator #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion projects/basic-calculator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,16 @@ function clearResult() {
}

function calculateResult() {
inputFieldEl.value = eval(inputFieldEl.value);

const expression = inputFieldEl.value;

// 🔥 VALIDATION: divide by zero detect
if (expression.includes("/0")) {
alert("Cannot divide by zero");
return;
}

inputFieldEl.value = eval(expression);
}

function appendValue(buttonValue) {
Expand Down