refactor: devScripts update @W-23474629@

eslint.config.mjs

@@ -0,0 +1 @@
+export { default } from 'eslint-config-salesforce-typescript';

package.json

@@ -26,13 +26,16 @@
   "devDependencies": {
     "@oclif/plugin-command-snapshot": "^5.3.33",
     "@salesforce/cli-plugins-testkit": "^5.3.64",
-    "@salesforce/dev-scripts": "^11.0.4",
+    "@salesforce/dev-scripts": "^13.0.1",
     "@salesforce/plugin-command-reference": "^3.1.128",
     "@salesforce/plugin-telemetry": "^3.8.33",
     "@salesforce/ts-sinon": "^1.4.36",
     "@types/cross-spawn": "^6.0.6",
+    "@types/semver": "^7.8.0",
     "@types/sinon-chai": "^3.2.12",
     "@types/which": "^3.0.4",
+    "eslint": "^10.4.0",
+    "eslint-config-salesforce-typescript": "^6.0.0",
     "eslint-plugin-sf-plugin": "^1.20.33",
     "oclif": "^4.23.29",
     "sinon-chai": "^3.7.0",
@@ -162,6 +165,7 @@
         "src/**/*.ts",
         "test/**/*.ts",
         "messages/**",
+        "**/eslint.config.*",
         "**/.eslint*",
         "**/tsconfig.json"
       ],

src/hooks/diagnostics.ts

@@ -114,13 +114,13 @@ const registryCheck = async (options: { doctor: SfDoctor }): Promise<void> => {
           // timeout after 5000ms, error
           if (!results || results.time > 5000) {
             // to trigger the catch/fail below
-            throw Error;
+            throw new Error('ping timeout or no response');
           }
           await Lifecycle.getInstance().emit('Doctor:diagnostic', {
             testName: `[${pluginName}] can ping: ${url}`,
             status: 'pass',
           });
-        } catch (e) {
+        } catch {
           await Lifecycle.getInstance().emit('Doctor:diagnostic', {
             testName: `[${pluginName}] can't ping: ${url}`,
             status: 'fail',

src/hooks/verifyInstallSignature.ts

@@ -30,7 +30,7 @@ import { type NpmName, parseNpmName } from '../shared/npmName.js';
 
 export const hook: Hook.PluginsPreinstall = async function (options) {
   const ux = new Ux();
-  if (options.plugin && options.plugin.type === 'npm') {
+  if (options.plugin?.type === 'npm') {
     const logger = await Logger.child('verifyInstallSignature');
     const plugin = options.plugin;
 

src/shared/allowlist.ts

@@ -67,7 +67,7 @@ export class AllowList {
   async #createAllowlistPath(): Promise<void> {
     try {
       await fs.promises.stat(this.#baseDir);
-    } catch (_) {
+    } catch {
       // we will try exactly once to blindly create the full directory. any error here will get bubbled back up to the caller
       await fs.promises.mkdir(this.#baseDir, { recursive: true });
     }

src/shared/errors.ts

@@ -23,7 +23,7 @@ import { SfError } from '@salesforce/core';
 export const setErrorName = (err: SfError, name: string): SfError => {
   // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   // @ts-ignore override readonly .name field
-  // eslint-disable-next-line no-param-reassign
+   
   err.name = name;
   return err;
 };

src/shared/installationVerification.ts

@@ -219,7 +219,7 @@ export class InstallationVerification implements Verifier {
    *
    * @param _pluginName the published plugin name
    */
-  public setPluginNpmName(_pluginName?: NpmName | undefined): InstallationVerification {
+  public setPluginNpmName(_pluginName?: NpmName  ): InstallationVerification {
     if (_pluginName) {
       this.pluginNpmName = _pluginName;
       return this;
@@ -443,17 +443,15 @@ export class InstallationVerification implements Verifier {
   }
 
   private async getLogger(): Promise<Logger> {
-    if (!this.logger) {
-      this.logger = await Logger.child('InstallationVerification');
-    }
+    this.logger ??= await Logger.child('InstallationVerification');
     return this.logger;
   }
 }
 
 export class VerificationConfig {
   public verifier?: Verifier;
   private ux = new Ux();
-  // eslint-disable-next-line class-methods-use-this
+   
   public log(message: string): void {
     this.ux.log(message);
   }
@@ -502,7 +500,7 @@ export const doInstallationCodeSigningVerification =
       if (err instanceof Error) {
         if (err.name === 'NotSigned' || err.message?.includes('Response code 403')) {
           if (!verificationConfig.verifier) {
-            throw new Error('VerificationConfig.verifier is not set.');
+            throw new Error('VerificationConfig.verifier is not set.', { cause: err });
           }
           return doPrompt(ux)(plugin.plugin);
         } else if (err.name === 'PluginNotFound' || err.name === 'PluginAccessDenied') {

test/nuts/node-info.nut.ts

@@ -41,7 +41,7 @@ describe('node info command', () => {
     await session?.zip(undefined, 'artifacts');
     try {
       await session?.clean();
-    } catch (error) {
+    } catch {
       // ignore
     }
   });

test/nuts/plugin-install.nut.ts

@@ -58,7 +58,7 @@ describe('plugins:install commands', () => {
     await session?.zip(undefined, 'artifacts');
     try {
       await session?.clean();
-    } catch (error) {
+    } catch {
       // ignore
     }
   });

test/nuts/sf-doctor.nut.ts

@@ -51,7 +51,7 @@ describe('sf doctor', () => {
     await session?.zip(undefined, 'artifacts');
     try {
       await session?.clean();
-    } catch (error) {
+    } catch {
       // ignore
     }
   });

test/shared/installationVerification.test.ts

@@ -32,7 +32,6 @@ import {
   getNpmRegistry,
   InstallationVerification,
   VerificationConfig,
-  Verifier,
 } from '../../src/shared/installationVerification.js';
 import { NpmMeta, NpmModule, NpmShowResults } from '../../src/shared/npmCommand.js';
 import { type NpmName, parseNpmName } from '../../src/shared/npmName.js';
@@ -579,7 +578,7 @@ describe('InstallationVerification Tests', () => {
             verified: true,
           };
         },
-      } as Verifier;
+      };
 
       vConfig.log = (_message) => {
         message = _message;
@@ -601,7 +600,7 @@ describe('InstallationVerification Tests', () => {
             verified: false,
           };
         },
-      } as Verifier;
+      };
 
       try {
         return await doInstallationCodeSigningVerification(new Ux())({}, BLANK_PLUGIN, vConfig);
@@ -621,7 +620,7 @@ describe('InstallationVerification Tests', () => {
         async isAllowListed() {
           return false;
         },
-      } as Verifier;
+      };
 
       stubMethod(sandbox, prompts, 'confirm').resolves(false);
 
@@ -644,7 +643,7 @@ describe('InstallationVerification Tests', () => {
         async isAllowListed() {
           return false;
         },
-      } as Verifier;
+      };
 
       stubMethod(sandbox, prompts, 'confirm').resolves(true);
 
@@ -667,7 +666,7 @@ describe('InstallationVerification Tests', () => {
         async isAllowListed() {
           return false;
         },
-      } as Verifier;
+      };
 
       stubMethod(sandbox, prompts, 'confirm').resolves(true);
 
@@ -692,7 +691,7 @@ describe('InstallationVerification Tests', () => {
         async isAllowListed() {
           return false;
         },
-      } as Verifier;
+      };
 
       stubMethod(sandbox, prompts, 'confirm').resolves(true);
 
@@ -717,7 +716,7 @@ describe('InstallationVerification Tests', () => {
         async isAllowListed() {
           return false;
         },
-      } as Verifier;
+      };
 
       stubMethod(sandbox, prompts, 'confirm').resolves(true);