Add Salt 3008 test coverage, driven off generate.py's version list#67
Merged
Conversation
Add 3008/3008.1 to generate.py's SALT_VERSIONS/VERSION_DISPLAY_NAMES and make it the single source of truth the test suites query (via new --print-versions/--print-upgrade-steps CLI modes), instead of hand-writing a new file or block per Salt major. The CI matrix now also derives one upgrade-<major> job per adjacent major pair, so future majors (3009, ...) only require a one-line edit to SALT_VERSIONS. - Windows: test_install_major.ps1, test_install_exact_ver.ps1, and test_upgrade.ps1 read $SALT_TEST_VERSION (set from matrix.instance) to test only their assigned version/step, or loop over everything when run locally without it. - Linux: test-linux.sh gains the same data-driven major/exact/upgrade checks, sourced from the real network (no new testarea binaries), and drops the stale "no 3008 GA yet" stub.
Keep a thin version check before the upgrade, but run the same status/binaries/service/config/ping/version battery Windows already runs after the upgrade, since that's the state that actually matters and it exercises the stop-old/start-new service transition that a fresh install never does.
Lets the full test suite (all versions, all jobs) be triggered on-demand from the Actions UI/gh CLI, or automatically once a week, without needing a PR to exercise the changed-files gate.
Drop binaries-present, PATH, and ping checks from the post-upgrade battery on both platforms - those are generic install checks already covered by the major/exact-version jobs. Keep status, service running, config preservation, and version bump, since those are the only things that actually exercise upgrade-specific behavior (stop-old/start-new transition, config carried forward). Cuts unnecessary work per upgrade CI job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add 3008/3008.1 to generate.py's SALT_VERSIONS/VERSION_DISPLAY_NAMES and make it the single source of truth the test suites query (via new --print-versions/--print-upgrade-steps CLI modes), instead of hand-writing a new file or block per Salt major. The CI matrix now also derives one upgrade- job per adjacent major pair, so future majors (3009, ...) only require a one-line edit to SALT_VERSIONS.