Skip to content

fix(parsers): inline directive JSON into bundle to stop srv-qa boot crash #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jung-thomas wants to merge 1 commit into from
Closed

fix(parsers): inline directive JSON into bundle to stop srv-qa boot crash #3042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions scripts/parsers/directives/reference-links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@
// node.label is non-empty. Directives that need a computed display label mutate
// node.label in their expand hook; render() then omits `label` from output.params.

import { createRequire } from 'module';
import type { DirectiveDef, DirectiveRenderOutput } from '../directive-registry.js';
import { DirectiveParseError } from '../directives.js';
import type { DirectiveNode, ExpandDirectivesContext } from '../directives.js';

// Load api-libs.json at module init time
const _require = createRequire(import.meta.url);
const API_LIBS: Record<string, string> = _require('./api-libs.json');
// Static default import so esbuild inlines the JSON into the parsers bundle.
// A runtime require left it external of parsers.bundle.mjs (same class of bug
// that crashed tutorials-srv-qa for icon-allowlist.json). resolveJsonModule is on.
import API_LIBS from './api-libs.json';

// ─── :tutorial-ref[slug]{label?} ─────────────────────────────────────────────
//
Expand Down
9 changes: 4 additions & 5 deletions scripts/parsers/directives/ui.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@
// Side-effect: call registerUiDirectives() once at startup.
// In tests: resetRegistry(); registerUiDirectives()

import { createRequire } from 'node:module';
import { registerDirective, getRegistry } from '../directive-registry.js';
import { DirectiveParseError } from '../directives.js';
import type { DirectiveNode } from '../directives.js';

const _require = createRequire(import.meta.url);
// eslint-disable-next-line @typescript-eslint/no-var-requires
const iconAllowlist: string[] = _require('./icon-allowlist.json') as string[];
// Static default import so esbuild inlines the JSON into the parsers bundle
// (parsers.bundle.mjs). A runtime require left it external and crashed
// tutorials-srv-qa at boot with MODULE_NOT_FOUND. resolveJsonModule is on.
import iconAllowlist from './icon-allowlist.json';

// ─── Key token constants ──────────────────────────────────────────────────────

Expand Down
Loading