Fix/restore Python 3.12 imagestreams - #838
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change adds Python 3.12 to UBI version lists and adds ChangesPython 3.12 UBI 8 support
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change restores Python 3.12 imagestream definitions without any identified merge-blocking risk; it is ready to merge after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
[test-all] |
Testing Farm results
|
hhorak
self-requested a review
August 19, 2026 12:10
hhorak
approved these changes
Aug 19, 2026
hhorak
left a comment
hhorak
left a comment
Member
There was a problem hiding this comment.
Thanks, LGTM, no issues spotted.
hhorak
requested changes
Aug 19, 2026
hhorak
left a comment
hhorak
left a comment
Member
There was a problem hiding this comment.
Hm, some tests did not succeed, taking back the approval before we know what's wrong.
Member
|
[test-openshift] |
hhorak
approved these changes
Aug 20, 2026
hhorak
left a comment
hhorak
left a comment
Member
There was a problem hiding this comment.
Still some failures, but since we're only touching imagestreams, we can only care about openshift tests. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores Python 3.12 imagestreams accidentaly removed in #828. Replaces #837.
Cc: @hhorak and @aroyoredhat
Summary by CodeRabbit