Skip to content

chore: update pr_maintainer_workflow to resolve breaking changes#660

Merged
andrewtavis merged 4 commits into
scribe-org:mainfrom
DeleMike:patch-1
Jul 21, 2026
Merged

chore: update pr_maintainer_workflow to resolve breaking changes#660
andrewtavis merged 4 commits into
scribe-org:mainfrom
DeleMike:patch-1

Conversation

@DeleMike

Copy link
Copy Markdown
Collaborator

Contributor checklist


Description

update actions to v3

@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙

The Scribe-iOS team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and iOS rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the CI unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo (can be set with git config --global user.email "GITHUB_EMAIL")

@DeleMike
DeleMike requested a review from andrewtavis July 21, 2026 10:09

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Great to have the support for all the repos, @DeleMike!

@andrewtavis

Copy link
Copy Markdown
Member

note: This PR now also restricts tests to be ran just on changes to Swift files :)

@andrewtavis
andrewtavis merged commit 26c88a9 into scribe-org:main Jul 21, 2026
@DeleMike
DeleMike deleted the patch-1 branch July 21, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants