Skip to content

Restore Pandas membership checks for string instance IDs #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sophiamaedler wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Restore Pandas membership checks for string instance IDs #1280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e0b250
replace np.isin with pd.isin
sophiamaedler Oct 19, 2026
e67602a
Merge branch 'main' into pandas_filter
sophiamaedler Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/spatialdata/_core/query/relational_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def _get_joined_table_indices(
-------
The indices that of the table that match the SpatialElement indices.
"""
mask = np.isin(table_instance_key_column.to_numpy(), element_indices)
mask = table_instance_key_column.isin(element_indices).to_numpy()
if joined_indices is None:
if match_rows == "left":
_, joined_indices = _match_rows(table_instance_key_column, mask, element_indices, match_rows)
Expand Down Expand Up @@ -232,7 +232,7 @@ def _get_masked_element(
-------
The masked spatial element based on the provided indices and match rows.
"""
mask = np.isin(table_instance_key_column.to_numpy(), element_indices)
mask = table_instance_key_column.isin(element_indices).to_numpy()
masked_table_instance_key_column = table_instance_key_column[mask]
mask_values: NDArray[Any] | pd.Index | None = (
masked_values if len(masked_values := masked_table_instance_key_column.to_numpy()) != 0 else None
Expand Down
Loading