test: regenerate TestLigrec baselines after per-permutation seeding#1240
Merged
Conversation
…1234) #1234 switched permutation tests to per-permutation seeds spawned from a numpy.random.SeedSequence, which changes ligrec results for a given seed. The TestLigrec dot-plot fixtures now yield a different set of significant interactions, so the rendered figure dimensions changed and the stale baselines failed with ImageComparisonFailure (size mismatch). Baselines regenerated from CI figure artifacts to match the new results.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
==========================================
+ Coverage 76.81% 77.08% +0.26%
==========================================
Files 63 63
Lines 9269 9368 +99
Branches 1565 1576 +11
==========================================
+ Hits 7120 7221 +101
+ Misses 1547 1545 -2
Partials 602 602 🚀 New features to boost your workflow:
|
selmanozleyen
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerate the three
TestLigrecplotting baselines.Why
#1234 changed permutation tests to spawn per-permutation seeds from a
numpy.random.SeedSequence(results now independent ofn_jobs/backend, but different for a givenseed). The ligrec dot-plot fixtures therefore select a different set of significant interactions, changing the figure dimensions. The stale baselines failed with:Reproduces on Linux and macOS (data change, not a rendering one), which is why it surfaced in daily integration testing (#1237/#1238/#1239) and on
mainCI starting at the #1234 commit.How
Baselines pulled from the failing run's
visual_test_results_Linuxfigure artifacts. The 3 tests pass locally against the new images.Closes #1237, closes #1238, closes #1239.