Repository navigation
docs: build the CPython example with CMake - #121
Merged
Merged
Conversation
Replace the setuptools setup.py with python_add_library, and describe the limited API through USE_SABI. Raise the CMake floor to 3.26. Assisted-by: ClaudeCode:claude-fable-5-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
The week 9 CPython notebook built its extension with
setup.py build_ext --inplace, but setuptools is not a declared dependency. It now uses CMake'spython_add_library, the same tool as the pybind11 notebook that follows.Development.SABIModuleandUSE_SABI 3.11, which need CMake 3.26, so the floor inpixi.tomlandenvironment.ymlgoes from 3.18 to 3.26.LIBRARY_PATHworkaround cell is removed. The notebook runs without it on one macOS machine; other setups are not tested.I also built the limited API variant by hand: it produces
pysimple.abi3.soand imports correctly.