Repository navigation
chore: bump Minuit2 example to ROOT 6.40.04 - #124
Merged
Merged
Conversation
ROOT 6.40 needs minuit2_standalone to build Minuit2 from the ROOT source tarball, and MnMigrad now takes MnUserParameterState and MnStrategy. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Updates the standalone Minuit2 example (
04-exampleand03b-pybind.ipynb) from ROOT 6.26.10 to 6.40.04.minuit2_standalone(withFORCE, so stale build caches pick it up). Without it, 6.40.04 fails to findROOT/RSpan.hxxwhen building from the ROOT tarball. This is fixed upstream in build(minuit2): modernize standalone CMake root-project/root#22788 (in 6.42), so the line can go after the next bump.MnMigradnow takesMnUserParameterStateandMnStrategy, so the binding uses apy::initfactory. The Python API is unchanged.6.40.4, since wheel names normalize away the leading zero.I built and ran the C++ app and the Python example locally, and ran the notebook against an old build directory.