Skip to content

Add SAE J1939 protocol support to Scapy contrib#4963

Open
polybassa wants to merge 1 commit intosecdev:masterfrom
polybassa:j1939_support
Open

Add SAE J1939 protocol support to Scapy contrib#4963
polybassa wants to merge 1 commit intosecdev:masterfrom
polybassa:j1939_support

Conversation

@polybassa
Copy link
Copy Markdown
Contributor

No description provided.

@polybassa
Copy link
Copy Markdown
Contributor Author

@BenGardiner Please review.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 59.33610% with 98 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.89%. Comparing base (366530e) to head (def7ba4).

Files with missing lines Patch % Lines
scapy/contrib/j1939.py 59.33% 98 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4963      +/-   ##
==========================================
+ Coverage   79.51%   79.89%   +0.38%     
==========================================
  Files         381      382       +1     
  Lines       93716    93957     +241     
==========================================
+ Hits        74521    75071     +550     
+ Misses      19195    18886     -309     
Files with missing lines Coverage Δ
scapy/contrib/j1939.py 59.33% <59.33%> (ø)

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@BenGardiner BenGardiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're gonna need a _Soft_J1939Socket too I think

Comment thread scapy/contrib/j1939.py
Comment thread scapy/contrib/j1939.py
Comment thread scapy/contrib/j1939.py
Comment thread scapy/contrib/j1939.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants