ci: add top-level read-only permissions to CI workflows - #1332
Open
sunitaprajapati89 wants to merge 3 commits into
Open
sunitaprajapati89 wants to merge 3 commits into
sunitaprajapati89 wants to merge 3 commits into
Conversation
CVE-2026-90711 (CVSS 9.1) was published against proxy-addr 2.0.7, and Artifactory's security-block-critical-cve-cvss-9-to-10 policy now refuses to serve that tarball. Every CI run fails at the install step as a result, regardless of what the branch changes. The last green build was 2026-09-09. express 4.22.1 already declares proxy-addr as ~2.0.7, which permits 2.0.8, so this is a lockfile re-resolution rather than a dependency bump. No package.json changes and no express upgrade are needed. proxy-addr reaches the graph only through express in examples/e2e-shared, so no published package was ever affected.
sunitaprajapati89
changed the title
sunitaprajapati89
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci.yml, e2e-tests.yml and publish-e2e-cli.yml did not declare a
permissions:block, so GITHUB_TOKEN inherited the repo/org default(read-write across all scopes). A compromised step or dependency install
script could have pushed commits, tampered with tags/releases, or
manipulated issues and PRs.
Set
permissions: contents: readat the top level of all three. Theci.yml jobs keep their existing job-level
id-token: writeforArtifactory OIDC; e2e-tests checks out the sibling repo with a dedicated
PAT and publish-e2e-cli only uploads an artifact, so neither needs more
than read.