Repository navigation
Encourage Agents to Proactively Offer Sent Feedback - #17
Conversation
There was a problem hiding this comment.
Looks good, straightforward documentation/eval change.
What was reviewed: the trigger-condition rewording and new "Offer feedback after meaningful friction" guardrails in the four duplicated sent-feedback SKILL.md copies (claude-plugins/, packages/, plugins/, skills/) — confirmed byte-for-byte identical across all four; the new eval/sent-feedback.yaml trigger/no_trigger/ambiguous cases, which read consistent with the stated rules; checked for a CODEOWNERS/ANTOWNERS file restricting these paths — none found.
Extended reasoning...
The change is a documentation/prompt update to the sent-feedback skill (broadening when it proactively offers a feedback report) duplicated in lockstep across four adapter copies, plus corresponding additions to the eval YAML test file; no code, auth, schema, or data-handling logic is touched. I verified the four SKILL.md copies are textually identical and the new eval cases are well-formed and consistent with the described rules. No CODEOWNERS/ANTOWNERS restricts these paths, the bug hunter found no issues, and the one ruled-out candidate (meta-dispatcher not inheriting the new proactive-offer wording) is a pre-existing design question unrelated to correctness of this diff, so this is simple enough to approve without further human review.
Changes / Fixes / Features included
This PR includes changes / features as below:
sent-feedbackskill was only activated when a user explicitly asked to pass feedback on, so most friction agents and users hit during Sent workflows never reached us.feedback.sendonly after explicit approval. Agent-offered reports setsourcetoagent.evals/sent-feedback.yamlfrom 5 to 14 cases, covering proactive triggers, non-triggers (fresh, routine, expected, unrelated, already-declined), and overlap withsent-messaging.skills/,plugins/sent/,claude-plugins/sent/).How to test?
In order to test changes included in the PR follow steps as below:
python3 scripts/generate_adapters.py --check. Generated adapters should match the canonical package.python3 scripts/validate.py,python3 scripts/test_validation_gates.py,python3 scripts/test_fixtures.py,python3 scripts/test_contracts.py, andpython3 scripts/test_live_contract.py. All should pass.claude plugin validate . --strictandclaude plugin validate ./claude-plugins/sent --strict. Both should pass.OPENAI_API_KEYset, runpython3 scripts/run_model_routing_eval.py. It should report at least 95% routing accuracy and 100% hard-negative success.feedback.sendonly after you approve it.