Skip to content

feat: Implement correlation on event filter#1386

Open
matheusandre1 wants to merge 1 commit into
serverlessworkflow:mainfrom
matheusandre1:feature/issue1206
Open

feat: Implement correlation on event filter#1386
matheusandre1 wants to merge 1 commit into
serverlessworkflow:mainfrom
matheusandre1:feature/issue1206

Conversation

@matheusandre1
Copy link
Copy Markdown
Contributor

@matheusandre1 matheusandre1 commented May 18, 2026

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it: Closes: #1206

Special notes for reviewers:

Additional information (if needed):

@matheusandre1 matheusandre1 marked this pull request as ready for review May 18, 2026 21:56
@matheusandre1 matheusandre1 requested a review from fjtirado as a code owner May 18, 2026 21:56
Copilot AI review requested due to automatic review settings May 18, 2026 21:56
Copilot AI reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

fjtirado
fjtirado reviewed May 19, 2026
View reviewed changes
Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/DSLWorkflowSamplesTest.java Outdated
fjtirado
fjtirado reviewed May 19, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/DefaultCloudEventPredicate.java Outdated
fjtirado
fjtirado reviewed May 19, 2026
View reviewed changes
Comment thread fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/UseBuilder.java
fjtirado
fjtirado reviewed May 19, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java Outdated
fjtirado
fjtirado requested changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to separate the DSL gap PR you were working on from the Correlation one.

@matheusandre1 matheusandre1 force-pushed the feature/issue1206 branch 2 times, most recently from d8d98e5 to 77143c1 Compare May 19, 2026 16:00
@matheusandre1 matheusandre1 marked this pull request as draft May 19, 2026 16:00
@matheusandre1 matheusandre1 marked this pull request as ready for review May 19, 2026 16:01
Copilot AI review requested due to automatic review settings May 19, 2026 16:01
@matheusandre1 matheusandre1 marked this pull request as draft May 19, 2026 16:01
Copilot AI reviewed May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java Outdated
Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/CorrelationTest.java Outdated
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/CorrelationPredicate.java Outdated
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/CorrelationPredicate.java Outdated
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/CorrelationPredicate.java Outdated
Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/CorrelationTest.java Outdated
Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/CorrelationTest.java Outdated
@matheusandre1
Copy link
Copy Markdown
Contributor Author

matheusandre1 commented May 19, 2026

@fjtirado I will send the other file separately after you review this one.

fjtirado
fjtirado reviewed May 20, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java Outdated
fjtirado
fjtirado reviewed May 20, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/CorrelationPredicate.java Outdated
fjtirado
fjtirado reviewed May 20, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java Outdated
fjtirado
fjtirado reviewed May 20, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/CorrelationPredicate.java Outdated
fjtirado
fjtirado reviewed May 20, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java Outdated
fjtirado
fjtirado reviewed May 20, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java Outdated
fjtirado
fjtirado reviewed May 20, 2026
View reviewed changes
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java Outdated
fjtirado
fjtirado reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fjtirado fjtirado left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think ColrreationPredicatre should be a CloudEventPredicate

@fjtirado fjtirado self-requested a review May 20, 2026 09:48
@matheusandre1 matheusandre1 marked this pull request as ready for review May 20, 2026 17:01
Copilot AI review requested due to automatic review settings May 20, 2026 17:01
Copilot AI reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.

Comment thread fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/dsl/AbstractEventFilterSpec.java Outdated
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/expressions/ExpressionFactory.java
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java Outdated
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/CorrelationPredicate.java
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/TypeEventRegistrationBuilder.java
Comment thread impl/test/src/test/java/io/serverlessworkflow/impl/test/CorrelationTest.java Outdated
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/CorrelationPredicate.java
Copilot AI review requested due to automatic review settings May 20, 2026 18:53
Copilot AI reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/expressions/ExpressionFactory.java Outdated
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/AbstractTypeConsumer.java
Comment thread impl/core/src/main/java/io/serverlessworkflow/impl/events/CorrelationPredicate.java
Comment thread fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/dsl/AbstractEventFilterSpec.java Outdated
@matheusandre1
feat: Implement correlation on event filter
37affd2 
- Add CorrelationPredicate for evaluating correlation expressions
- Add correlate support in AbstractEventFilterBuilder and AbstractEventFilterSpec
- Update TypeEventRegistration and TypeEventRegistrationBuilder with correlation predicates
- Implement correlation matching in AbstractTypeConsumer
- Add CorrelationTest and listen-correlate.yaml
- Add correlate tests in WorkflowBuilderTest and DSLTest

Signed-off-by: Matheus André <matheusandr2@gmail.com>
Copilot AI review requested due to automatic review settings May 20, 2026 20:57
Copilot AI reviewed May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@fjtirado fjtirado Awaiting requested review from fjtirado fjtirado is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat: Implement correlation on event filter

3 participants

@matheusandre1 @fjtirado