Skip to content

python(bug): assets.archive AttributeError fix - #747

Merged
wei-qlu merged 1 commit into
mainfrom
eng-13794-sift_client-archive_asset-reads-a-response-field-that-does
Aug 20, 2026
Merged

python(bug): assets.archive AttributeError fix#747
wei-qlu merged 1 commit into
mainfrom
eng-13794-sift_client-archive_asset-reads-a-response-field-that-does

Conversation

@wei-qlu

@wei-qlu wei-qlu commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixes assets.archive() raising AttributeError: the wrapper read archived_runs, but the proto field is archived_run_ids.
  • Adds unit tests for archive_asset.

Before:

image

After:

image

@wei-qlu
wei-qlu requested a review from solidiquis August 20, 2026 07:13
@github-actions

Copy link
Copy Markdown
Contributor

Python docs preview: https://sift-stack.github.io/sift/python/pr-747/

Deployed from 789d140. The link may take up to a minute to become live as GitHub Pages propagates.

@wei-qlu
wei-qlu requested a review from alexluck-sift August 20, 2026 07:17
@wei-qlu
wei-qlu merged commit b096b82 into main Aug 20, 2026
26 checks passed
@wei-qlu
wei-qlu deleted the eng-13794-sift_client-archive_asset-reads-a-response-field-that-does branch August 20, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants