Clean up PCPATR Preparer a little - #1055
Draft
papeh wants to merge 2 commits into
Draft
Conversation
* Capture newly-created ICmPossibilityLists directly when created to simplify logic and prevent race condition interceptions (none proven) * Remove unused usings * Make Cache and ShowMessages properties readonly
SmartGit is reluctant to compare files with lines over 10k characters.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
==========================================
+ Coverage 38.01% 38.04% +0.02%
==========================================
Files 1499 1499
Lines 349945 350096 +151
Branches 40229 40229
==========================================
+ Hits 133048 133199 +151
Misses 187616 187616
Partials 29281 29281
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Summary
There is a problem with the cache not getting updated immediately when these lists are created. I don't expect these changes to fix this problem, but I can't imagine them doing any harm, and they remove a theoretical possibility of interference.
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.This change is