Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4040 +/- ##
=======================================
Coverage 81.10% 81.10%
=======================================
Files 661 661
Lines 43060 43060
Branches 7059 7059
=======================================
Hits 34925 34925
- Misses 6962 6977 +15
+ Partials 1173 1158 -15 ☔ View full report in Codecov by Harness. |
Nateowami
left a comment
There was a problem hiding this comment.
@Nateowami made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on marksvc).
mongodb/Projects/annotate-test-project-reasons.py line 1 at r1 (raw file):
#!/usr/bin/env python3
Why python? I understand every language has its positives and negatives, but at least the languages one is most familiar with will be, well, more familiar and easier to reason about. I would prefer not to introduce another language the team has to work with without a good reason (I know there are already like 5 Python files in the project).
|
@Nateowami It's because
|
Nateowami
left a comment
There was a problem hiding this comment.
That's actually a completely fair reason I didn't think of. Though if we can limit it to just the script to be run on the server that's probably preferable.
@Nateowami made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on marksvc).
|
📸 Screenshot diff deployed! (11 changes) View the visual diff at: https://pr-4040--sf-screenshot-diffs.netlify.app |
The determine- processing could not be moved into the mongodb script at this time since the DB does not reliably state project visibility.
|
I rolled one of the 2 python scripts into the mongodb script. |
Open in Devin Review
This change is