Skip to content

SF-3064 Pause audio playback before starting recording - #4056

Merged
Nateowami merged 1 commit into
masterfrom
fix/SF-3064-pause-audio-playback-before-recording
Aug 19, 2026
Merged

SF-3064 Pause audio playback before starting recording#4056
Nateowami merged 1 commit into
masterfrom
fix/SF-3064-pause-audio-playback-before-recording

Conversation

@Nateowami

@Nateowami Nateowami commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.10%. Comparing base (821f2d5) to head (2e67c0c).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4056      +/-   ##
==========================================
+ Coverage   81.09%   81.10%   +0.01%     
==========================================
  Files         661      661              
  Lines       43057    43060       +3     
  Branches     7054     7054              
==========================================
+ Hits        34916    34925       +9     
+ Misses       6965     6962       -3     
+ Partials     1176     1173       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Aug 19, 2026
@Nateowami
Nateowami marked this pull request as ready for review August 19, 2026 14:11
@RaymondLuong3 RaymondLuong3 self-assigned this Aug 19, 2026

@RaymondLuong3 RaymondLuong3 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaymondLuong3 reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@Nateowami
Nateowami enabled auto-merge (squash) August 19, 2026 16:52
@Nateowami
Nateowami force-pushed the fix/SF-3064-pause-audio-playback-before-recording branch from 7419ed9 to 2e67c0c Compare August 19, 2026 17:04
@Nateowami
Nateowami deployed to screenshot_diff August 19, 2026 17:18 — with GitHub Actions Active
@Nateowami
Nateowami merged commit ab39994 into master Aug 19, 2026
28 checks passed
@Nateowami
Nateowami deleted the fix/SF-3064-pause-audio-playback-before-recording branch August 19, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants