rts: clarify connect method - #4060
Merged
Merged
Conversation
Contributor
|
✅ No screenshot differences — all stories are identical. View the diff page at: https://pr-4060--sf-screenshot-diffs.netlify.app |
marksvc
marked this pull request as ready for review
August 19, 2026 22:43
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4060 +/- ##
==========================================
- Coverage 81.03% 81.03% -0.01%
==========================================
Files 661 661
Lines 43107 43108 +1
Branches 7062 7036 -26
==========================================
Hits 34931 34931
- Misses 7017 7018 +1
Partials 1159 1159 ☔ View full report in Codecov by Harness. |
RealtimeServer.connect is overloaded and used for different things. This patch changes the overloads to add clarity to how connect is used, not used, and the implications.
pmachapman
force-pushed
the
task/rts-connect
branch
from
August 23, 2026 22:08
f6c872f to
64837a3
Compare
pmachapman
self-requested a review
August 23, 2026 22:09
pmachapman
approved these changes
Aug 23, 2026
pmachapman
left a comment
Collaborator
There was a problem hiding this comment.
@pmachapman reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on marksvc).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RealtimeServer.connect is overloaded and used for different things.
This patch changes the overloads to add clarity to how connect is
used, not used, and the implications.
connectmethod in a followup change. This patch makes ourconnectoverloads more plain, and the followup change should be less confusing as a result.Open in Devin Review
This change is