Skip to content

rts: clarify connect method - #4060

Merged
pmachapman merged 1 commit into
masterfrom
task/rts-connect
Aug 23, 2026
Merged

rts: clarify connect method#4060
pmachapman merged 1 commit into
masterfrom
task/rts-connect

Conversation

@marksvc

@marksvc marksvc commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

RealtimeServer.connect is overloaded and used for different things.

This patch changes the overloads to add clarity to how connect is
used, not used, and the implications.


  • I want to modify the connect method in a followup change. This patch makes our connect overloads more plain, and the followup change should be less confusing as a result.
  • This patch should not be changing behaviour, but just adding clarity. (Except there is an added Warning.)
  • You may notice unpleasant things as you review this. The patch here isn't trying to improve the behaviour, but preserve it.

Open in Devin Review


This change is Reviewable

@marksvc
marksvc marked this pull request as draft August 19, 2026 22:34
@marksvc
marksvc deployed to screenshot_diff August 19, 2026 22:42 — with GitHub Actions Active
@marksvc marksvc added testing not required e2e Run e2e tests for this pull request labels Aug 19, 2026
@github-actions

github-actions Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

No screenshot differences — all stories are identical.

View the diff page at: https://pr-4060--sf-screenshot-diffs.netlify.app

@marksvc
marksvc marked this pull request as ready for review August 19, 2026 22:43
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.03%. Comparing base (8d20922) to head (64837a3).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/RealtimeServer/common/realtime-server.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4060      +/-   ##
==========================================
- Coverage   81.03%   81.03%   -0.01%     
==========================================
  Files         661      661              
  Lines       43107    43108       +1     
  Branches     7062     7036      -26     
==========================================
  Hits        34931    34931              
- Misses       7017     7018       +1     
  Partials     1159     1159              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

RealtimeServer.connect is overloaded and used for different things.

This patch changes the overloads to add clarity to how connect is
used, not used, and the implications.
@pmachapman
pmachapman self-requested a review August 23, 2026 22:09
@pmachapman pmachapman self-assigned this Aug 23, 2026
@pmachapman
pmachapman deployed to screenshot_diff August 23, 2026 22:16 — with GitHub Actions Active

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on marksvc).

@pmachapman
pmachapman merged commit 129dc0b into master Aug 23, 2026
30 checks passed
@pmachapman
pmachapman deleted the task/rts-connect branch August 23, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants