Skip to content

fix(logs): right-size and reorganize log-detail action chips#5352

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/log-details-chip-sizing
Jul 2, 2026
Merged

fix(logs): right-size and reorganize log-detail action chips#5352
waleedlatif1 merged 1 commit into
stagingfrom
fix/log-details-chip-sizing

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up polish to feat(logs): add Troubleshoot in Chat button for errored runs #5341: the "View Snapshot" and "Troubleshoot in Chat" chips in the Log Details panel were disproportionately heavy — both used variant='primary' (the solid inverse-fill chip), which is reserved platform-wide for a single standout action per context (Save, Upgrade, Add key), never a peer among several row actions. Two solid pills stacked in a narrow side panel read as oversized against Settings' equivalent rows, which stay bare.
  • The Version badge was size='md' while its siblings (Level, Trigger) are size='sm' — an inconsistency.
  • Reorganized: "Troubleshoot in Chat" was a floating, label-less chip sitting below Workflow Output. Folded it into the Details card as its own row (identical treatment to "Snapshot"), so every row in the card now shares one shape (label left, trailing content right) top to bottom.

Type of Change

  • UI polish / design-consistency fix

Testing

  • Verified live in the running app (light + dark) — panel now reads calm and consistently aligned, matching the Settings row rhythm.
  • type-check, biome, check:client-boundary, check:api-validation all pass on an isolated branch (no unrelated changes).

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Two concrete regressions from the earlier Chip conversion (#5341):
- Both chips used variant='primary' (the solid inverse-fill treatment),
  the heaviest chrome in the design system, reserved for a single standout
  action per context (Save, Upgrade, Add key) — never a peer among several
  row actions. Two solid pills stacked in a narrow side panel read as
  oversized. Switched both to the bare (default) chip, matching every
  analogous row action in Settings.
- The Version badge was size='md' while its siblings (Level, Trigger) are
  size='sm' — an inconsistency. Aligned to 'sm'.

Also folded the floating 'Troubleshoot in Chat' chip into the Details card
as its own row (matching 'Snapshot' exactly) instead of leaving it orphaned
below Workflow Output — every row in the card now shares one shape (label
left, trailing content right), consistent top to bottom.
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 2, 2026 2:43am

Request Review

@cursor

cursor Bot commented Jul 2, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Presentation-only changes in the logs UI; no API, auth, or execution logic touched.

Overview
Polishes the Log Details overview so metadata rows and actions read consistently with Settings-style layout.

The Version badge is size='sm' so it matches Level and Trigger. View Snapshot and Troubleshoot in Chat no longer use variant='primary' on Chip, avoiding two heavy solid pills in a narrow panel.

Troubleshoot in Chat moves from a standalone chip below Workflow Output into the Details card as a labeled row (label left, chip right), same pattern as Snapshot. Troubleshoot behavior is unchanged.

Reviewed by Cursor Bugbot for commit 7ab2fee. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR is a focused UI polish pass on the Log Details panel: it normalizes the Version badge from size='md' to size='sm' to match the Level and Trigger badges, drops variant='primary' from both action chips (defaulting to the bare-pill style), and relocates the "Troubleshoot in Chat" chip out of a freestanding position below Workflow Output into the Details card as a consistent label-left / chip-right row.

  • Badge size normalization: size='md'size='sm' on the Version badge aligns it with every other badge in the same card section.
  • Chip variant alignment: Removing variant='primary' from both the Snapshot and Troubleshoot chips replaces the heavy inverse-fill style with the default bare pill, matching how peer action rows look elsewhere in the platform.
  • Layout unification: The Troubleshoot row is now an h-10 flex items-center justify-between px-3 row inside the Details card — identical in shape to the Snapshot row directly above it.

Confidence Score: 5/5

This is a pure layout and styling change — no business logic, state, or data-fetching is touched.

All three modifications are isolated to JSX props and element positioning within one component. The existing Eye and Wrench icon imports were already present, the Troubleshoot onClick handler is unchanged, and conditional guards (showWorkflowState, canTroubleshoot) are unaffected. The only runtime difference is visual.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx Three cosmetic changes: Badge size md→sm, variant='primary' removed from Snapshot and Troubleshoot chips, Troubleshoot row moved into the Details card with consistent label/chip layout. No logic changes; existing imports (Eye, Wrench) were already in scope.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Details Card] --> B[Level row]
    A --> C[Trigger row]
    A --> D[Duration row]
    A --> E[Version row\nbadge size='sm']
    A --> F{showWorkflowState?}
    F -->|yes| G[Snapshot row\nChip default variant]
    A --> H{canTroubleshoot?}
    H -->|yes| I[Troubleshoot row\nChip default variant\n moved here from below Workflow Output]

    style G fill:#d4edda,stroke:#28a745
    style I fill:#d4edda,stroke:#28a745
    style E fill:#d4edda,stroke:#28a745
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Details Card] --> B[Level row]
    A --> C[Trigger row]
    A --> D[Duration row]
    A --> E[Version row\nbadge size='sm']
    A --> F{showWorkflowState?}
    F -->|yes| G[Snapshot row\nChip default variant]
    A --> H{canTroubleshoot?}
    H -->|yes| I[Troubleshoot row\nChip default variant\n moved here from below Workflow Output]

    style G fill:#d4edda,stroke:#28a745
    style I fill:#d4edda,stroke:#28a745
    style E fill:#d4edda,stroke:#28a745
Loading

Reviews (1): Last reviewed commit: "fix(logs): right-size and reorganize log..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit b346088 into staging Jul 2, 2026
13 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/log-details-chip-sizing branch July 2, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant