Skip to content

fix(brex): surface isPproEnabled in transfer block outputs#5373

Merged
waleedlatif1 merged 1 commit into
stagingfrom
brex-transfer-output-fix
Jul 2, 2026
Merged

fix(brex): surface isPproEnabled in transfer block outputs#5373
waleedlatif1 merged 1 commit into
stagingfrom
brex-transfer-output-fix

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to improvement(brex): fill validate-integration gaps against live API docs #5362: the final confirmatory /validate-integration pass found that get_transfer/list_transfers tool outputs already include isPproEnabled/is_ppro_enabled, but the block's declared outputs map was missing it — making it unreachable from the workflow UI
  • Adds isPproEnabled to the block outputs alongside the other transfer fields

Type of Change

  • Bug fix

Testing

Tested manually. bun run lint and bun run type-check pass clean.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Tool-level get_transfer/list_transfers already returned is_ppro_enabled
(confirmed present on Brex's live Transfer schema), but the block's
outputs map didn't declare it, so it was unreachable from the workflow
UI. Adds it alongside the other transfer output fields.
@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 2, 2026 3:59pm

Request Review

@cursor

cursor Bot commented Jul 2, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Metadata-only change to block output declarations; no runtime or API behavior changes.

Overview
Adds isPproEnabled (boolean) to the Brex block’s declared outputs for Get Transfer / List Transfers, matching what the Brex tools already return.

Without this entry, Principal Protection (PPRO) status was present in tool responses but not selectable in the workflow UI when wiring downstream blocks.

Reviewed by Cursor Bugbot for commit e65b8e9. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds isPproEnabled to the BrexBlock block-level outputs map, closing the gap between what the underlying get_transfer and list_transfers tools already return and what the workflow UI can address.

  • The get_transfer tool already maps data.is_ppro_enabled → isPproEnabled in transformResponse and declares it in its own outputs; the block-level declaration was simply missing, making the field invisible to downstream workflow nodes.
  • The new entry uses type: 'boolean', consistent with both tool-level definitions, and omits optional in line with every other field in the block's flat outputs map.

Confidence Score: 5/5

Safe to merge — one-line addition to a declarative outputs map with no runtime logic changes.

The change is a single declarative addition to a flat outputs map. The underlying tool implementations already produce isPproEnabled correctly; this just surfaces it to the workflow UI. Nothing is executed differently at runtime.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/blocks/blocks/brex.ts Adds isPproEnabled (boolean) to the block-level outputs map so the field returned by get_transfer/list_transfers is reachable from the workflow UI; no logic changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Workflow UI selects transfer operation] --> B{get_transfer or list_transfers?}
    B -- get_transfer --> C[brexGetTransferTool.transformResponse\nmaps is_ppro_enabled → isPproEnabled]
    B -- list_transfers --> D[brexListTransfersTool.transformResponse\nreturns items array with is_ppro_enabled]
    C --> E[BrexBlock outputs map]
    D --> E
    E --> F{isPproEnabled declared?}
    F -- Before PR --> G[Missing — field unreachable in UI]
    F -- After PR --> H[Present — field accessible in UI]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Workflow UI selects transfer operation] --> B{get_transfer or list_transfers?}
    B -- get_transfer --> C[brexGetTransferTool.transformResponse\nmaps is_ppro_enabled → isPproEnabled]
    B -- list_transfers --> D[brexListTransfersTool.transformResponse\nreturns items array with is_ppro_enabled]
    C --> E[BrexBlock outputs map]
    D --> E
    E --> F{isPproEnabled declared?}
    F -- Before PR --> G[Missing — field unreachable in UI]
    F -- After PR --> H[Present — field accessible in UI]
Loading

Reviews (1): Last reviewed commit: "fix(brex): surface isPproEnabled in tran..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit 7fd89bc into staging Jul 2, 2026
18 checks passed
@waleedlatif1 waleedlatif1 deleted the brex-transfer-output-fix branch July 2, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant