Add spell name and spell id to json for sequences#11406
Open
Pewtro wants to merge 2 commits intosimulationcraft:midnightfrom
Open
Add spell name and spell id to json for sequences#11406Pewtro wants to merge 2 commits intosimulationcraft:midnightfrom
Pewtro wants to merge 2 commits intosimulationcraft:midnightfrom
Conversation
Pewtro
force-pushed
the
feature/sequence-spellnames-and-ids
branch
from
33c1848 to
d593357
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently sequences on raidbots don't have their ability name shown:
https://www.raidbots.com/simbot/report/77MSb8YdNstdj7X8nLRiKY
This aims to fix that by supplying the action id and action name appropriately into the json for sequences