Skip to content

[11.2] Devourer spell execution reordering #11517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aezeor wants to merge 1 commit into
base: midnight
Choose a base branch
from
+7 −5
Open

[11.2] Devourer spell execution reordering #11517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions engine/class_modules/sc_demon_hunter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5588,6 +5588,7 @@ struct consume_base_t : public shattered_souls_trigger_t<voidfall_building_trigg
{
dh()->buff.moment_of_craving->trigger();
dh()->cooldown.reap->reset( true );
dh()->buff.soulburst->expire();
dh()->spawn_soul_fragment( dh()->proc.soul_fragment_from_soulburst, soul_fragment::LESSER,
as<unsigned int>( dh()->set_bonuses.mid2_devourer_4pc->effectN( 1 ).base_value() ) );
}
Expand Down Expand Up @@ -5622,7 +5623,6 @@ struct consume_base_t : public shattered_souls_trigger_t<voidfall_building_trigg
if ( dh()->buff.soulburst->up() && soulburst )
{
soulburst->execute_on_target( target );
dh()->buff.soulburst->expire();
}
}
};
Expand Down Expand Up @@ -5891,9 +5891,6 @@ struct reap_base_t : public voidfall_spending_trigger_t<meteoric_fall_trigger_t<

void execute() override
{
dh()->buff.reap->trigger();

base_t::execute();
unsigned fragments_consumed = dh()->consume_soul_fragments( soul_fragment::LESSER, false, souls_to_consume() );

// TOCHECK: Is this instant?
Expand All @@ -5904,6 +5901,10 @@ struct reap_base_t : public voidfall_spending_trigger_t<meteoric_fall_trigger_t<
dh()->buff.soulburst->trigger();
}

dh()->buff.reap->trigger();

base_t::execute();

// TOCHECK: This delay is a guess based on averages in logs as there is no spelldata
make_event( *dh()->sim, 220_ms, [ this, fragments_consumed ] {
damage_action->set_target( target );
Expand Down Expand Up @@ -5987,11 +5988,12 @@ struct eradicate_t : public voidfall_spending_trigger_t<meteoric_fall_trigger_t<

void execute() override
{
unsigned fragments_consumed = dh()->consume_soul_fragments( soul_fragment::LESSER, false, souls_to_consume() );

dh()->buff.reap->trigger();

base_t::execute();

unsigned fragments_consumed = dh()->consume_soul_fragments( soul_fragment::LESSER, false, souls_to_consume() );
auto damage = dh()->buff.metamorphosis->up() ? damage_action_meta : damage_action;

// TOCHECK: This delay is a guess based on averages in logs as there is no spelldata
Expand Down
Loading