Skip to content

[Devourer] Model Voidfall building procs as a pseudo-random distribution #11538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToppleTheNun merged 2 commits into from
Jun 28, 2026
+14 −5
Merged

[Devourer] Model Voidfall building procs as a pseudo-random distribution #11538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b6063f
[Devourer] Model Voidfall building procs as a pseudo-random distribution
taherbert Jun 26, 2026
9a35e99
[DH] remove unnecessary assignment
ToppleTheNun Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions engine/class_modules/sc_demon_hunter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,6 +1159,13 @@ class demon_hunter_t : public parse_player_effects_t
{
} shuffled_rng;

// Accumulated proc objects
struct accumulated_rngs_t
{
// Annihilator
accumulated_rng_t* voidfall;
} accumulated_rng;

// Special
struct actives_t
{
Expand Down Expand Up @@ -2959,14 +2966,12 @@ struct voidfall_building_trigger_t : public BASE
if ( !BASE::dh()->talent.annihilator.voidfall->ok() )
return;

if ( !BASE::rng().roll( BASE::dh()->talent.annihilator.voidfall->effectN( 3 ).percent() ) )
// can't build (or roll) while spending is up
if ( BASE::dh()->buff.voidfall_spending->up() )
return;

// can't gain building while spending is up
if ( BASE::dh()->buff.voidfall_spending->up() )
{
if ( !BASE::dh()->accumulated_rng.voidfall->trigger() )
return;
}

BASE::dh()->proc.voidfall_from_builder->occur();
BASE::dh()->buff.voidfall_building->trigger(
Expand Down Expand Up @@ -10442,6 +10447,10 @@ void demon_hunter_t::init_rng()
break;
}

// Accumulated proc objects
accumulated_rng.voidfall = get_accumulated_rng(
"voidfall", prd::find_constant( talent.annihilator.voidfall->effectN( 3 ).percent() ) );

player_t::init_rng();
}

Expand Down
Loading