Skip to content

[monk] Use Profileset Controller to validate talents - #11551

Merged
renanthera merged 12 commits into
simulationcraft:midnightfrom
renanthera:12.1/68301-use-profileset-controller-to-validate-talents
Jul 14, 2026
Merged

renanthera merged 12 commits into
simulationcraft:midnightfrom
renanthera:12.1/68301-use-profileset-controller-to-validate-talents

Conversation

@renanthera

Copy link
Copy Markdown
Member
  • [monk] Use a profileset controller to gracefully handle profilesets that include impermissible Monk hero talent configurations.
  • [profileset_control] Fix a deadlock caused when profileset_work_threads is set to a value greater than 1 and cancellations occur at similar times.
  • [monk] Allow valid_talents to permit sims using enable_all_talents option.
  • [monk] Allow talent verification to occur for non-profileset sims.

@renanthera
renanthera merged commit 3da71f0 into simulationcraft:midnight Jul 14, 2026
83 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant