fix(ci): type-check nested examples with mypy . - #200
Merged
Conversation
CI ran `mypy ./**/*.py`, but the workflow's non-interactive bash has globstar off, so `**` collapses to `*` and the glob only matches one directory level (src/*.py). Every example living under src/<family>/ was silently skipped — the type-check step reported "no issues found in 1 source file" while checking only an empty __init__.py. Switch to `mypy .`, which uses mypy's own recursion and checks the whole showcase tree. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
added
github_actions
zimeg
marked this pull request as ready for review
August 18, 2026 21:58
zimeg
enabled auto-merge (squash)
August 18, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CI's type-check step runs
mypy ./**/*.py. The workflow's non-interactivebash -ehasglobstaroff, so**degrades to*and the glob only matches one directory level —src/*.py. Every example undersrc/<family>/is silently skipped.Evidence: the
methodsjob logsSuccess: no issues found in 1 source file— it type-checks only an emptysrc/__init__.py, never the examples.Fix
mypy .— mypy's own recursion walks the whole showcase tree (verified: checks 17 files inmethods/vs. 1 before).Heads-up before merge
This makes type-checking real for every nested example, so it will surface any latent
attr-defined(or other) errors that were previously hidden repo-wide — not just in one family. Draft so a maintainer can review what turns red and fix or triage before this gatesmain.(Independent of the Code Channels example PRs #194/#199, whose examples call not-yet-released typed SDK methods and are expected to fail this stricter check until those methods ship.)