docs(types): align Alert, Card, Carousel block descriptions with official docs#2578
Merged
docs(types): align Alert, Card, Carousel block descriptions with official docs#2578
Conversation
🦋 Changeset detectedLatest commit: 243d857 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 62 62
Lines 10256 10256
Branches 415 415
=======================================
Hits 8963 8963
Misses 1272 1272
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
@srtaalej Can we add milestones and labels before merging? |
srtaalej
added
docs
Member
|
☝️ Changed from "3.x" to "next" so it's included with next release - IIRC "3.x" is for issues but we might want to find a better pattern for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlertBlockdescription to "Displays alerts, warnings, and informational messages."CardBlockdescription to "Displays content in a card."CarouselBlockdescription to "Displays related card blocks in a horizontally-scrolling container."These align with the official Slack documentation and follow the existing "Displays..." pattern used by other blocks in the codebase.
Test plan
npm run buildpasses for@slack/typesnpm test(tsd type tests) passes for@slack/types