ChipIngress: Introduce per-event idempotency keys#2199
Merged
Conversation
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a per-event idempotency key as a CloudEvent extension attribute emitted by NewEvent, enabling downstream consumers (e.g., via Kafka header mappings) to deduplicate events.
Changes:
- Introduced
IdempotencyKeyAttrconstant defining the extension attribute name. - Updated
NewEventto setidempotencykeyas a CloudEvent extension when present and non-empty. - Added unit tests validating extension presence/absence behavior for the idempotency key.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/chipingress/types.go | Adds the exported IdempotencyKeyAttr constant and associated documentation. |
| pkg/chipingress/client.go | Sets the idempotency key extension on newly created CloudEvents when provided. |
| pkg/chipingress/client_test.go | Adds coverage ensuring the idempotency key extension is set only when non-empty. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkcll
previously approved these changes
Jun 25, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
pkcll
approved these changes
Jun 25, 2026
patrickhuie19
approved these changes
Jun 25, 2026
patrickhuie19
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for an idempotency key as a CloudEvent extension attribute in the
NewEventfunction, allowing downstream consumers to deduplicate events.Idempotency Key Support:
IdempotencyKeyAttrintypes.goto define the CloudEvent extension attribute name for idempotency keys, with documentation explaining its usage and behavior in ChIP Ingress and Kafka headers.NewEventinclient.goto set the idempotency key as a CloudEvent extension if provided and non-empty in theattributesmap.