chore: implement phase 4 - #2782
Open
Tofel wants to merge 3 commits into
Open
Conversation
📊 API Diff Results
|
Tofel
force-pushed
the
dx-5122-alerts-assertion-p4
branch
2 times, most recently
from
September 1, 2026 14:18
28b0170 to
8e00518
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p4
branch
2 times, most recently
from
September 2, 2026 09:45
e38c815 to
904571c
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p4
branch
from
September 4, 2026 15:03
904571c to
034847e
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p4
branch
from
September 7, 2026 09:35
034847e to
ee1286d
Compare
Tofel
marked this pull request as ready for review
September 7, 2026 09:36
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
There are correctness and API-surface issues in the new scheduling code/tests (including misleading test expectation output and missing validation/guards) that should be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Implements “phase 4” scheduling primitives for grafana-alertcheck by deriving per-rule and global timing thresholds, introducing a per-rule scheduler, and adding a schedule feasibility (“budget”) check, with accompanying tests.
Changes:
- Added
schedule.gowithDeriveTimings,Scheduler,CheckBudget, andStartupSummary. - Moved
skewHardLimitfromsource.gointo the new schedule constants block. - Added comprehensive unit tests for timing derivation, scheduling behavior, budget checks, and a new resolve form test.
File summaries
| File | Description |
|---|---|
| grafana-alertcheck/internal/gate/source.go | Moves skewHardLimit out of source.go now that scheduling code exists. |
| grafana-alertcheck/internal/gate/schedule.go | Adds timing derivation, per-rule scheduler, budget check, and startup summary formatting. |
| grafana-alertcheck/internal/gate/schedule_test.go | Adds tests covering timing derivation, scheduler ordering/cadence, budget failure modes, and startup summary warnings. |
| grafana-alertcheck/internal/gate/resolve_test.go | Adds test coverage for resolving the Folder/Title alert name form. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+228
to
+240
| for _, uid := range uids { | ||
| rt, m := t[uid], measured[uid] | ||
| utilization += float64(m) / float64(rt.pollEvery) | ||
| if t[tightestUID].pollEvery > rt.pollEvery { | ||
| tightestUID = uid | ||
| } | ||
| if m > maxMeasured { | ||
| maxMeasured, maxMeasuredUID = m, uid | ||
| } | ||
| if m > rt.pollEvery { | ||
| overCadence = append(overCadence, uid) | ||
| } | ||
| } |
Tofel
force-pushed
the
dx-5122-alerts-assertion-p4
branch
from
September 7, 2026 09:46
ee1286d to
c36b86f
Compare
Add per-rule poll timings, scheduler, and budget check (P4). - schedule.go: DeriveTimings, Scheduler, CheckBudget (§5) - Address review: add Folder/Title resolve test, rename CheckBudget's minPollEvery to tightestUID
Tofel
force-pushed
the
dx-5122-alerts-assertion-p4
branch
from
September 7, 2026 15:02
c36b86f to
cc2dd22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds per-rule poll timings, the scheduler, and the budget check.
Review focus:
schedule.go—DeriveTimings,Scheduler,CheckBudget.