chore: use testify's require in tests

[Tofel]

Migrates all test assertions from hand-rolled t.Fatal/Error to testify require, adds the testify dependency, and adds a recorder-mode fail-fast in check.go for from < StartedAt.

Review focus: the check.go fail-fast (the only non-test change); the rest is a mechanical assertion swap.

[github-actions]

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-testing-framework/grafana-alertcheck

⚠️ Breaking Changes (1)

package github (1)

• com/smartcontractkit/chainlink-testing-framework/grafana-alertcheck/cmd/grafana-alertcheck — 🗑️ Removed

✅ Compatible Changes (1)

package github (1)

• com/smartcontractkit/chainlink-testing-framework/grafana-alertcheck/cmd — ➕ Added

---

📄 View full apidiff report

[Copilot]

🟡 Changes recommended

The new recorder-mode fail-fast can mask log-identity failures, and a couple of updated tests use require.Fail from goroutines via observeAll, which is unreliable.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR standardizes the Grafana alertcheck test suite on testify/require for fail-fast assertions, adds the testify module dependency, and introduces a recorder-mode “fail fast” in internal/gate/check.go when from is before the recorded header’s StartedAt.

Changes:

• Replace hand-rolled t.Fatal/t.Error patterns across tests with require.* assertions.
• Add github.com/stretchr/testify (and indirect YAML dep) to go.mod/go.sum.
• Add a recorder-mode early exit in check.go for the statically-detectable from < StartedAt bound violation.

File summaries

File	Description
grafana-alertcheck/internal/gate/watch_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/watch_daemon_test.go	Mechanical migration of assertions to require in integration-style daemon tests.
grafana-alertcheck/internal/gate/source_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/schedule_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/resolve_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/parse_state_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/parse_ruler_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/log_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/jsonreq_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/duration_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/coverage_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/classify_test.go	Mechanical migration of assertions to require.
grafana-alertcheck/internal/gate/check.go	Adds recorder-mode fail-fast when from precedes StartedAt.
grafana-alertcheck/internal/gate/check_test.go	Updates tests to require and adds coverage for the new fail-fast path.
grafana-alertcheck/go.mod	Adds testify dependency (and indirect YAML dep).
grafana-alertcheck/go.sum	Adds checksums for newly introduced dependencies.
grafana-alertcheck/cmd/grafana-alertcheck/watch_test.go	Mechanical migration of CLI tests to require.
grafana-alertcheck/cmd/grafana-alertcheck/table_test.go	Mechanical migration of table rendering tests to require.
grafana-alertcheck/cmd/grafana-alertcheck/main_test.go	Mechanical migration of CLI entrypoint tests to require.
grafana-alertcheck/cmd/grafana-alertcheck/list_test.go	Mechanical migration of CLI list tests to require.
grafana-alertcheck/cmd/grafana-alertcheck/check_test.go	Mechanical migration of CLI check tests to require.

Review details

Suppressed comments (1)

grafana-alertcheck/internal/gate/check_test.go:895

• This responder can be invoked from goroutines via observeAll during the drain wait. require.Fail triggers FailNow from a worker goroutine, which doesn't reliably stop the test. Prefer returning an error (the caller path already makes the test fail by violating the require.NoError assertion).

		src := newCheckSource(func(title string, _ int) (Observation, error) {
			require.Fail(t, fmt.Sprintf("the drain wait polled skipped rule %q", title))
			return Observation{}, errors.New("unexpected poll")
		})

• Files reviewed: 20/21 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.