[PLEX - 2742] - local cre + simple latest block e2e test#23015
[PLEX - 2742] - local cre + simple latest block e2e test#23015ilija42 wants to merge 24 commits into
Conversation
d300103 to
6450f8a
Compare
CORA - Pending Reviewers
Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
I see you updated files related to
|
|
✅ No conflicts with other open PRs targeting |
|
| // path (config.go requires a valid C-address). Reads (GetLatestLedger / | ||
| // ReadContract) never call the forwarder. Milestone B replaces this with the | ||
| // address of the deployed CRE forwarder. | ||
| placeholderForwarder = "CDLZFC3SYJYDZT7K67VZ75HPJVIEUVNIXF47ZG2FB2RMQQVU2HHGCYSC" |
There was a problem hiding this comment.
are these three: requestTimeout, deltaStage and placeholderForwarder defaults? should it be possible to overwrite them via TOML and capability config? or not currently?
There was a problem hiding this comment.
requestTimeout is part of the onchain capability config and is usually configured by writing the config to the contract, the other two are part of the capability config job spec
|
|
||
| // registerStellarCapability registers the Stellar chain capability with its read | ||
| // methods. WriteReport / LogTrigger are Milestone B. | ||
| func registerStellarCapability(selector uint64) []keystone_changeset.DONCapabilityWithConfig { |
There was a problem hiding this comment.
technically this doesn't register anything, it just creates an object representing the configuration, why not inline it at the callsite?
| } | ||
|
|
||
| func Test_CRE_V2_Stellar_Suite(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
since we only have 1 test for stellar environment, why is this needed? in the future if we have more will that also work? or will we need to do, what we do for tests that share the environment and need to use different private keys?
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0989a12bce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0989a12 to
05390f0
Compare
|




Requires
Supports