Attach required type label to all custmsg emitters#23024
Draft
pkcll wants to merge 2 commits into
Draft
Conversation
Add core/custmsgtypes constants and use WithType/WithLabelsAndType at every custmsg call site. Local go.mod replace points at task worktree for common.
Remove local replace so CI can resolve the dependency from the chainlink-common PR branch.
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/custmsgtypeswith stable type constants (NodeConfig, Heartbeat, WorkflowEngine, WorkflowSyncer, WorkflowArtifact, Compute)custmsg.NewLabeler()call sites to chain.WithType(...)before emitchainlink-commonto branch pseudo-versionv0.11.2-0.20260703215130-fb7f626f085cDepends on smartcontractkit/chainlink-common#2222 — merge common first, then re-bump to released pseudo-version before merging this PR.
Test plan
go test ./core/cmd/ -run TestShell_emitNodeConfiggo test ./core/services/workflows/syncer/...go test ./core/services/workflows/artifacts/...go test ./core/capabilities/compute/go test ./core/services/workflows/v2/...