Skip to content

fix(pipeline): allow literal ethtx from addresses - #23378

Open
JasonColapietro wants to merge 1 commit into
smartcontractkit:developfrom
JasonColapietro:agent/fix-ethtx-literal-from-address
Open

fix(pipeline): allow literal ethtx from addresses#23378
JasonColapietro wants to merge 1 commit into
smartcontractkit:developfrom
JasonColapietro:agent/fix-ethtx-literal-from-address

Conversation

@JasonColapietro

Copy link
Copy Markdown

Summary

  • allow ethtx task from fields to use a single literal Ethereum address
  • preserve variable-expression, JSON-array, and existing fallback handling
  • reject trailing JSON data instead of silently accepting the first value
  • add focused parser, getter, and task regression coverage

Root cause

The from resolver tried variable and JSON parsing before its string fallback. A bare 0x... address is not valid JSON and therefore could not be resolved as an address slice.

Impact

Pipeline specs can pin an ethtx task to one literal address without wrapping it in a JSON array. Existing variable and array forms remain supported.

Validation

  • gofmt -d on all changed Go files
  • go test ./core/services/pipeline -run '^(TestGetters_JSONWithVarExprs|TestETHTxFromGetters_LiteralAddress)$' -count=1
  • git diff --check

The broader TestETHTxTask table requires CL_DATABASE_URL; it was not runnable in the local environment and is left to CI.

@JasonColapietro
JasonColapietro marked this pull request as ready for review August 12, 2026 22:09
@JasonColapietro
JasonColapietro requested review from a team as code owners August 12, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant