fix(pipeline): allow literal ethtx from addresses - #23378
Open
JasonColapietro wants to merge 1 commit into
Open
Conversation
JasonColapietro
marked this pull request as ready for review
August 12, 2026 22:09
product-security-plaid-production
Bot
requested review from
Unheilbar,
pavel-raykov and
prashantkumar1982
August 12, 2026 22:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ethtxtaskfromfields to use a single literal Ethereum addressRoot cause
The
fromresolver tried variable and JSON parsing before its string fallback. A bare0x...address is not valid JSON and therefore could not be resolved as an address slice.Impact
Pipeline specs can pin an
ethtxtask to one literal address without wrapping it in a JSON array. Existing variable and array forms remain supported.Validation
gofmt -don all changed Go filesgo test ./core/services/pipeline -run '^(TestGetters_JSONWithVarExprs|TestETHTxFromGetters_LiteralAddress)$' -count=1git diff --checkThe broader
TestETHTxTasktable requiresCL_DATABASE_URL; it was not runnable in the local environment and is left to CI.