Repository navigation
Implement updated standard retry behavior - #733
Merged
Alan4506 merged 13 commits intoAug 7, 2026
Merged
Conversation
SamRemis
previously requested changes
Jul 7, 2026
SamRemis
reviewed
Jul 7, 2026
Alan4506
force-pushed
the
retries-2.1-sep-update-v2
branch
from
July 14, 2026 21:19
e5e0c7d to
18d19e6
Compare
Alan4506
force-pushed
the
retries-2.1-sep-update-v2
branch
from
July 14, 2026 21:22
18d19e6 to
a900e8c
Compare
Alan4506
force-pushed
the
retries-2.1-sep-update-v2
branch
from
July 16, 2026 15:32
51e469d to
7b6c346
Compare
…ent pyright issue
arandito
reviewed
Aug 5, 2026
arandito
reviewed
Aug 7, 2026
Alan4506
dismissed
SamRemis’s stale review
August 7, 2026 21:17
Another reviewer has reviewed the changes.
arandito
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates the standard retry behavior:
error.is_throttling_error.RETRY_COSTis now 14, throttling retries cost 5, and the timeout-specific cost is removed.smithy.api#longPolltrait at runtime throughAPIOperation.long_polling.x-amz-retry-after: honored when returned by the service, capped at 5 seconds above the normal backoff; invalid/missing values fall back to normal backoff and the standard HTTPRetry-Afteris ignored.Note on long-polling detection:
Some service models don't apply the
smithy.api#longPolltrait yet. We deliberately do not hard-code those operations. Doing this would require codegen interface changes for temporary behavior. The trait lookup is the long-term design regardless. Until those service models apply the trait, those operations won't get long-polling backoff.Testing:
Added unit tests for each change (throttling vs non-throttling backoff, quota costs, the quota-exhaustion backoff contract, and
x-amz-retry-afterparsing/clamping/wiring). Also updated affected functional tests. All Python checks pass (make check-py,make test-py) and the Java codegen builds successfully.Follow-up:
The awsJson protocol's
_create_erroris not ondevelopyet (it lives on the json-rpc branch). Once that merges, it needs the sameparse_retry_after(response)wiring that awsQuery already has, sox-amz-retry-afteris honored for awsJson services (e.g. DynamoDB) too.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.