Skip to content

[All] Fix some scenes - #6322

Merged
epernod merged 7 commits into
sofa-framework:masterfrom
bakpaul:26_09_fix_some_scenes_for_ci
Sep 29, 2026
Merged

epernod merged 7 commits into
sofa-framework:masterfrom
bakpaul:26_09_fix_some_scenes_for_ci

Conversation

@bakpaul

@bakpaul bakpaul commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Some scenes are broken since the PR on integration schemes : the changes to these scenes seem to have been wrongly merged by github. This might be due to recent pr modifying those files and the merge messing around.

Some other come from missing required plugins

[with-all-tests]
[ci-depends-on https://github.com/sofa-framework/SofaImplicitField/pull/4]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Sep 25, 2026
@bakpaul
bakpaul marked this pull request as ready for review September 25, 2026 15:14
@bakpaul bakpaul changed the title [All] Fix forgotten required plugins or EulerImplicitSolver [All] Fix some scenes Sep 28, 2026
@sofabot

sofabot commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #5.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #6.

To unlock the merge button, you must

@sofabot

sofabot commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #7.

To unlock the merge button, you must

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 29, 2026
@sofabot

sofabot commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #8.

All dependencies are merged/closed. Congrats! 👍

@epernod
epernod merged commit 3efd78b into sofa-framework:master Sep 29, 2026
16 of 22 checks passed
bakpaul added a commit to bakpaul/sofa that referenced this pull request Sep 29, 2026
* Firx forgotten required plugins or EulerImplicitSolver

* Add scenes from examples

* Fix xml files

* Fix missing required plugins

* add proper required plugin so scene is skipped

---------

Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
Lucas-TJ pushed a commit to Lucas-TJ/sofa that referenced this pull request Oct 2, 2026
* Firx forgotten required plugins or EulerImplicitSolver

* Add scenes from examples

* Fix xml files

* Fix missing required plugins

* add proper required plugin so scene is skipped

---------

Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants