[RNE Rewrite] style(ts): rename opts to options - #1358
Merged
Conversation
msluszniak
approved these changes
Aug 10, 2026
msluszniak
added a commit
that referenced
this pull request
Aug 12, 2026
Brings the OCR pipeline in line with the conventions that landed on rne-rewrite while this branch was open. - The three OCR-specific native ops were called straight off `rnexecutorchJsi.cv` from inside the task files. add-native-extension requires task-specific ops to be wrapped in `src/extensions/<domain>/utils/<name>.ts` and re-exported from the domain index, the way vadUtils/supertonicUtils/privacyFilterUtils are, so power users can reach them: new `cv/utils/ocrUtils.ts` with typed, documented `extractCraftTextBoxes` / `extractDbnetTextBoxes` / `ctcGreedyDecode`. - Five bare `throw new Error` (geometry, detectors, documentModels, quad ops) now carry codes: INVALID_ARGUMENT for a caller's bad input, INVALID_STATE for calling table recognition on models loaded without a table config. Documented with `@throws` on the entry points that can raise them. - `opts` parameters renamed to `options` (#1358): `makeCraftExtractBoxes`, `makeDbnetExtractBoxes`, `rectifyQuad`. - `OcrModel.ocrOpts` -> `modelOpts`, matching every other task's model type. - Tensor locals carry the `t` prefix the pipeline skill asks for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes naming from
optstooptionsacross the board in TS API. Follow-up to comment from #1317Introduces a breaking change?
Type of change
Tested on
Testing instructions
N/A
Screenshots
Related issues
Checklist
Additional notes