initial implementation of the groth16 verifier - #2
Conversation
samkim-crypto
left a comment
samkim-crypto
left a comment
There was a problem hiding this comment.
I am just starting to take a look at the PR and looking good so far! I have a couple initial comments below regarding the organization.
My main suggestion is to extract the repository scaffolding, build configuration, and CI into a small prerequisite PR, merge that first, and then rebase this PR. That would let us establish a working CI baseline and keep this review focused on the implementation.
|
|
||
| | Path | Kind | Purpose | | ||
| | ----------------------- | ------------- | --------------------------------------------------------------------------- | | ||
| | `tools/convert/` | `rlib`, `std` | `groth16-convert`: host-side bridge from gnark and arkworks serialization to the on-chain form, used by the tests and by clients preparing keys | |
There was a problem hiding this comment.
Just for my own understanding, is the groth16-convert crate for testing purposes only or is it meant to be used publicly by clients? I am seeing publish = false in Cargo.toml for the crate, so I assume it is only for testing purposes? If so, then we should reword the README here.
There was a problem hiding this comment.
yes it is for testing purpose only. i will reword it
|
this got merged/closed because of a forced push. reopen this PR as #4 |
2 participants
No description provided.