token-lending: harden Pyth product attr parsing (avoid OOB panic)#223
Open
yukikm wants to merge 4304 commits into
Open
token-lending: harden Pyth product attr parsing (avoid OOB panic)#223yukikm wants to merge 4304 commits into
yukikm wants to merge 4304 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens parsing of
pyth::Product.attrin token-lending to ensure malformed attribute data cannot trigger an out-of-bounds panic.Changes:
get_pyth_product_quote_currencywith full bounds checks (panic → clean error).token-lending/program/PYTH_ATTR_PANIC_WRITEUP.md.Why: On-chain programs should never panic on untrusted account data; panics become deterministic instruction failures (DoS for the affected path).