Merged
Conversation
Mirrors the existing pimStorage / solidStorage / storageUrls getters. Solid-OIDC mandates solid:oidcIssuer for issuer discovery; downstream consumers (reactive-fetch, the ODI Solid browser extension) currently subclass Agent to add this same getter. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class support for Solid-OIDC WebID Issuer Discovery on the core Agent model by introducing an oidcIssuers getter that reads solid:oidcIssuer values from the WebID profile, consistent with existing storage discovery getters.
Changes:
- Add
Agent.oidcIssuersgetter backed bySetFrom.subjectPredicateonsolid:oidcIssuer. - Add unit test coverage ensuring multiple
solid:oidcIssuertriples are returned as a set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/webid/Agent.ts | Adds oidcIssuers getter using the same set-based extraction pattern as solidStorage. |
| test/unit/agent.test.ts | Verifies the getter returns all issuer URLs when multiple issuers are declared. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
langsamu
approved these changes
Apr 23, 2026
Contributor
langsamu
left a comment
There was a problem hiding this comment.
Minor naming consistency request.
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
Co-authored-by: Samu Lang <langsamu@users.noreply.github.com>
langsamu
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an
oidcIssuersgetter onAgentthat returns the values ofsolid:oidcIssuertriples on the WebID profile, mirroring the existingpimStorage/solidStorage/storageUrlsgetters.solid:oidcIssueris the predicate Solid-OIDC mandates for WebID-Issuer Discovery (see Solid-OIDC spec, WebID-Issuer Discovery section). Downstream consumers —@jeswr/solid-reactive-fetch'sWebIDProfileAgentand the ODI Solid browser extension'sinject.ts— currently subclassAgentpurely to add this same getter. Hosting it on the baseAgentlets both packages drop the subclass.The implementation is a one-line addition that delegates to
SetFrom.subjectPredicateexactly assolidStoragedoes, so it picks up the sameSet<string>semantics consumers already rely on for storage discovery.Test plan
test/unit/agent.test.tsverifies the getter returns both values when a WebID declares multiplesolid:oidcIssuertriples.npm testpasses (22/22 tests).