Repository navigation
fix: follow solid-js rc.10 attribution API (NavigationRef, history(type)); peer ^2.0.0-rc.10 - #628
Merged
Merged
Conversation
…pe)); peer ^2.0.0-rc.10
🦋 Changeset detectedLatest commit: a283098 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Minimal compatibility fix so the published router builds and tests against
solid-js@2.0.0-rc.10/rc.11.src/routers/factory.tsx:import type { NavigationRef } from "solid-js"(was"solid-js/attribution").test/observe-navigation.spec.tsx:attribution.history("navigation")in place ofattribution.navigations().README.md: the one prose mention ofattribution.navigations()updated toattribution.history("navigation")(feedback().navigationsis unchanged in rc.11 and stays as-is).package.json: peer range forsolid-jsand@solidjs/web^2.0.0-rc.9→^2.0.0-rc.10; devDependencies moved to^2.0.0-rc.11;pnpm-lock.yamlregenerated accordingly (pnpm i --frozen-lockfilepasses).patch).Why
solid-js@2.0.0-rc.10changed the attribution surface (solidjs/solid235173e,384a631):InteractionRef/NavigationRefmoved offsolid-js/attributiononto the mainsolid-jsentry, andattribution.navigations()/interactions()/holds()/waterfalls()collapsed intoattribution.history(type). Routernext(4658036, published2.0.0-next.30) still uses the old surface while declaring peersolid-js ^2.0.0-rc.9, so any lockfile-less install resolves rc.11 and fails:tscreportsTS2305: Module '"solid-js/attribution"' has no exported member 'NavigationRef', and 6 specs fail withattribution.navigations is not a function.These are exactly the two compat edits already present in #623 (
feat/declare-initial-route), lifted out on their own. #623 additionally depends on the unreleased solidjs/solid#3683 (NavigationRef.initial/RenderEvent.route); once this lands, #623 rebases onto it and becomes feature-only. No initial-route code is included here.Tests (local,
solid-js@2.0.0-rc.11/@solidjs/web@2.0.0-rc.11)nextHEAD (before)pnpm build(tsc + rollup + fs gate)factory.tsxvitest run)vitest.config.server.ts)tsc --project tsconfig.test.json)All six client failures were
attribution.navigations is not a functioninobserve-navigation.spec.tsx; all now pass.Pre-existing, unrelated:
test/exact-optional-types.spec.tscompiles a fixture through the TypeScript compiler API inside a 5 s test timeout and times out under CPU contention (e.g. two vitest processes at once). Reproduced identically onnextHEAD before this change; passes when the machine is idle (5/5 idle runs on this branch).Public API changes
solid-js^2.0.0-rc.9→^2.0.0-rc.10@solidjs/web^2.0.0-rc.9→^2.0.0-rc.10No exports, props, options, or runtime behaviour change.
— Claude via Cursor