WIP: Upgrade to solid 2 beta by brenelz · Pull Request #2091 · solidjs/solid-start

brenelz · 2026-03-04T21:00:00Z

PR Checklist

Seeing what It take to update SolidStart to use Solid 2.0 beta. The examples work even with solid-router

netlify · 2026-03-04T21:00:06Z

✅ Deploy Preview for solid-start-landing-page ready!

Name	Link
🔨 Latest commit	`c597710`
🔍 Latest deploy log	https://app.netlify.com/projects/solid-start-landing-page/deploys/6a4e94f39bd7ff00088d14be
😎 Deploy Preview	https://deploy-preview-2091--solid-start-landing-page.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

changeset-bot · 2026-03-04T21:00:08Z

⚠️ No Changeset found

Latest commit: c597710

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new · 2026-03-04T21:00:49Z

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2091

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2091

commit: c597710

brenelz · 2026-03-04T21:01:55Z

-    useAssets_(() => renderAsset(asset, nonce));
-    entity.ssrIdx = ssrRequestAssets.length - 1;
+    useAssets_(() => renderAsset(asset, nonce) as any);
+    if (ssrRequestAssets) {


im not sure if these changes are correct or needed

brenelz · 2026-03-04T21:02:23Z

+// used on native HTML elements during SSR transformation.  The previous
+// implementation used JSX (<style {...props.attrs}> etc.) which triggered the
+// bug.  Instead we build the HTML strings directly — these assets are only
+// ever rendered during SSR so reactive JSX is unnecessary.


these changes are probably unneeded

seems that they are needed in some capacity

lxsmnsyc · 2026-03-17T06:56:29Z

We can probably use ^2.0.0-beta.3 based on my tests

lxsmnsyc · 2026-03-21T15:58:51Z

needs rebasing

- Update leftover accessor-style children callbacks to beta.15 semantics: non-keyed <For> and keyed <Show> now pass raw values, not accessors (notes, hackernews, todomvc fixtures + one missed spot in the dev overlay) - Patch terracotta to shim removed @solidjs/web createDynamic export - Align @solidjs/signals in apps/tests with solid-js 2.0.0-beta.15 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

# Conflicts: # apps/tests/vite.config.ts # packages/start/package.json # packages/start/src/config/index.ts # packages/start/src/fns/handler.ts # packages/start/src/fns/server.ts # packages/start/src/server/handler.ts # pnpm-lock.yaml

- onSettled no longer accepts async callbacks (a returned Promise is an invalid cleanup value) — wrap the async work in a void IIFE across the test routes, and convert main's new server-env route from createEffect(async) to the same pattern - dev overlay: Errored's fallback now receives an accessor, and signal writes inside the boundary's owned scope throw — read the error and defer the push to a microtask Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

In Solid 2, createEffect's compute runs during SSR, so the export check executed on the server — where the "use server" module legitimately still exports testQuery — baking "true" into the markup. Use onSettled (a server no-op) like the other server-function routes so the check runs against the client module, where non-function exports are stripped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

terracotta next.6 migrated to solid 2.0.0-beta.15 (own createDynamic helper, JSX types from @solidjs/web), so the pnpm patch shimming the removed @solidjs/web createDynamic export is no longer needed, and the dev overlay's Select props no longer need the `as any` cast. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

katywings · 2026-07-08T09:06:55Z

-
-const lazy = !isServer
-  ? solidLazy
-  : <T extends Component<any>>(fn: () => Promise<{ default: T }>) => solidLazy(withAssets(fn));


Why are you removing all of my css work? 🙈

I honestly can't remember. Maybe it had issues. Let me try and add it back

added it back

brenelz · 2026-07-08T14:59:01Z


+import { pageRoutes } from "./routes.ts";
+
+function buildDevManifest(): Record<string, any> {


this is the most critical change that was made for v2 i think

Bring back the withAssets logic in shared/lazy.ts (id$$ manifest lookup + useAssets injection with nonce), adapted to beta.15 where lazy() takes a required moduleUrl in SSR: - config/lazy.ts: inject vite-plugin-solid's __SOLID_LAZY_MODULE__ placeholder into user-land lazy() calls before rewriting the solid-js import, since the plugin only injects it for "solid-js" imports - server/handler.ts: resolve unknown moduleUrls in the dev manifest via a Proxy fallback so client hydration can preload lazy modules in dev - css fixture: replace removed createAsync with createMemo, pass an explicit moduleUrl for the import.meta.glob lazy, and fix onSettled returning a non-cleanup value Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

The raw-HTML-string workaround existed for a babel-plugin-jsx-dom-expressions spread crash that's fixed in 0.50.0-next.14. The remaining blocker was beta.15's owner-based hydration keys: useAssets thunks run at shell-injection time with no owner, so ssrElement's getNextContextId call threw and killed the server process. Wrapping the asset JSX in <NoHydration> provides an owner with hydration-key generation disabled — correct for head tags, which never hydrate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

brenelz added 2 commits March 4, 2026 13:46

Initial upgrade to solid v2

05bf908

Fix hydration mismatch

a26c9b4

brenelz commented Mar 4, 2026

View reviewed changes

Comment thread packages/start/package.json Outdated

brenelz added 7 commits March 4, 2026 20:44

fixes

984a368

dedupe solid and solid-router

1c0efad

fixture tweaks

de8272b

more hackernews tweaks

ad6c458

fixes

6d3a870

upgrade to newest solid beta

cc134c5

Reset landing page to v1 because of kobalte

57c529f

brenelz commented Mar 7, 2026

View reviewed changes

Comment thread packages/start/src/fns/handler.ts

brenelz commented Mar 7, 2026

View reviewed changes

Comment thread packages/start/src/shared/dev-overlay/DevOverlayDialog.tsx Outdated

lockfile changes

656cda1

lxsmnsyc reviewed Mar 9, 2026

View reviewed changes

Comment thread packages/start/package.json Outdated

brenelz added 4 commits March 10, 2026 09:17

use solidjs next version

91a89a8

ugprade to beta.2

3dc43fc

fix lockfile

39e4a8f

Upgrade to solid v2 beta.3

a7cf407

brenelz and others added 5 commits March 17, 2026 20:08

Update to latest solid meta

91720b4

Update router deps

b7a253d

Merge branch 'main' into upgrade-to-solid-2-beta

4c7cfc9

Fix tests

b6c3480

feat(2.0): terracotta@next (#2118)

a4e888d

brenelz and others added 10 commits March 21, 2026 15:04

Merge branch 'main' into upgrade-to-solid-2-beta

0083bba

upgrade to beta.4

d2867e7

Update to solid 2.0.0-beta.6

480f830

chore: upgrade to solidjs beta 7

1da1504

update to solidjs beta.15

6a5107a

katywings reviewed Jul 8, 2026

View reviewed changes

brenelz commented Jul 8, 2026

View reviewed changes

brenelz and others added 3 commits July 8, 2026 10:25

update to solidjs beta.16

c597710


		import { pageRoutes } from "./routes.ts";

		function buildDevManifest(): Record<string, any> {

Uh oh!

Conversation

brenelz commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Uh oh!

netlify Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for solid-start-landing-page ready!

Uh oh!

changeset-bot Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

pkg-pr-new Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brenelz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

brenelz Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

brenelz Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lxsmnsyc commented Mar 17, 2026

Uh oh!

lxsmnsyc commented Mar 21, 2026

Uh oh!

katywings Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

brenelz Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

brenelz Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

brenelz Jul 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brenelz commented Mar 4, 2026 •

edited

Loading

netlify Bot commented Mar 4, 2026 •

edited

Loading

changeset-bot Bot commented Mar 4, 2026 •

edited

Loading

pkg-pr-new Bot commented Mar 4, 2026 •

edited

Loading