Skip to content

chore: stabilize flaky ci tests - #2225

Merged
birkskyum merged 1 commit into
mainfrom
stabilize-flaky-ci-tests
Jul 21, 2026
Merged

chore: stabilize flaky ci tests#2225
birkskyum merged 1 commit into
mainfrom
stabilize-flaky-ci-tests

Conversation

@birkskyum

@birkskyum birkskyum commented Jul 21, 2026

Copy link
Copy Markdown
Member

During CI Vite warns about:

[vitest] Vite unexpectedly reloaded a test. This may cause tests to fail, lead to flaky behaviour or duplicated test runs.
For a stable experience, please add mentioned dependencies to your config's optimizeDeps.include field manually.

So this adds the testing library to teh optimizeDeps, so vite deosn't warn about flakiness.

This also adds a small timeout on the hydration tests which is flaky.

These issues are why teh ci currently fails in e.g.

@netlify

netlify Bot commented Jul 21, 2026

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit fe88597
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6a5fb7c4cae8fa00087b22f1
😎 Deploy Preview https://deploy-preview-2225--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: fe88597

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@birkskyum
birkskyum requested a review from brenelz July 21, 2026 18:17
@pkg-pr-new

pkg-pr-new Bot commented Jul 21, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2225

commit: fe88597

@birkskyum
birkskyum merged commit 38faf5d into main Jul 21, 2026
10 checks passed
@birkskyum
birkskyum deleted the stabilize-flaky-ci-tests branch July 21, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants