fix: reject server function calls on 5xx responses without X-Error - #2261
Merged
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: b5c3e74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
adipascu
force-pushed
the
fix/server-fn-5xx-rejection-v2
branch
from
July 28, 2026 15:49
749f1af to
66f3088
Compare
adipascu
marked this pull request as ready for review
July 28, 2026 16:27
adipascu
force-pushed
the
fix/server-fn-5xx-rejection-v2
branch
from
July 28, 2026 16:36
66f3088 to
f0db21f
Compare
birkskyum
reviewed
Jul 28, 2026
brenelz
added a commit
that referenced
this pull request
Jul 29, 2026
Brings the v2 rc line (through 2.0.0-rc.6) into the Solid 2 branch. Ported main features onto the Solid 2 architecture: - Server-function error handler (#2262): wired through handleServerFunctionRequest's transformResult hook and the solid-start:server-fn-error-handler virtual module. - Custom seroval plugins (#2250): serialization.plugins now feeds the @solidjs/web codec on both the client transport and the server handler. - ~ alias fix for workspace packages (#2239): adopted appRootAlias in place of the global resolve.alias entry. - Dev toolbar (#2049, replaces the dev overlay): ported to Solid 2 (Errored/Loading, onSettled, two-arg createEffect, draft-mutation stores, terracotta 2 subpath imports, @solidjs/web Portal/Dynamic/JSX, createMemo(async) instead of createResource). Protocol-specific pieces (SerovalChunkReader, body-format markers) moved local to the toolbar. - Deferred stream response via h3 iterable() (#2231), StartHandler type (#2234), routerLoad restore (#2228), nonce on streaming redirect script (#2252), ResizeObserver-loop filter (#2240) all kept. Kept deleted (superseded by vite-plugin-solid / @solidjs/web / @solidjs/router server-function integration): fs-routes tree-shake, manifest.ts, directives, fns serialization/registration/shared and their specs. Fixes main landed in those files (#2249, #2238, #2243, #2245, #2241, #2261) live upstream now and are tracked for porting there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Server function calls only reject when the response carries an
X-Errorheader. Two cases slip past that check inpackages/start/src/fns/client.ts:X-Error, so the promise resolves and callers mistake server failure for success.undefined, so callers have no error to inspect or match on.Minimal reproduction: https://github.com/adipascu/solid-start-server-fn-500-repro
What is the new behavior?
Responses with status >= 500 throw the deserialized result the same way
X-Errordoes, falling back to anErrorcarrying the status when the body yields nothing. 4xx responses are untouched, since server functions can legitimately return them withoutX-Error.Other information
This is the follow-up to #2159, which was merged onto
1.xwhere I asked whether to retarget it atmain. v2's rewritten client has the same logic, so the same fix applies.Added
packages/start/src/fns/client.spec.tsbeside the existinghandler.spec.ts. Both regression tests were confirmed to fail without the source change.