Skip to content

chore(deps): upgraded to latest dependencies#242

Open
Sourav-kashyap wants to merge 2 commits intomasterfrom
ratelimiter
Open

chore(deps): upgraded to latest dependencies#242
Sourav-kashyap wants to merge 2 commits intomasterfrom
ratelimiter

Conversation

@Sourav-kashyap
Copy link
Copy Markdown

Description

Upgraded loopback4-ratelimiter to use the latest versions of rate-limiting dependencies, migrate from older versions to the latest stable releases.

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine

Build Passed:

Screenshot 2026-03-20 at 3 35 24 PM

TestCases Passed:

Screenshot 2026-03-20 at 3 35 42 PM

@Sourav-kashyap Sourav-kashyap self-assigned this Mar 20, 2026
@Sourav-kashyap Sourav-kashyap added the dependencies Pull requests that update a dependency file label Mar 20, 2026
@Sourav-kashyap Sourav-kashyap force-pushed the ratelimiter branch 4 times, most recently from f48b3d6 to 6592e7f Compare March 20, 2026 13:19
Comment thread src/__tests__/acceptance/store.provider.ts Outdated
@yeshamavani
Copy link
Copy Markdown
Contributor

@Sourav-kashyap trivy failing

@Sourav-kashyap Sourav-kashyap force-pushed the ratelimiter branch 2 times, most recently from b00af02 to 3a35863 Compare March 23, 2026 14:02
@Sourav-kashyap Sourav-kashyap force-pushed the ratelimiter branch 4 times, most recently from c35ed52 to 66fea91 Compare April 2, 2026 09:39
upgraded to latest dependencies

GH-0
@sonarqubecloud
Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Upgrade LoopBack rate-limiter package and express-rate-limit to latest versions while updating GitHub Actions and improving type safety.

Review Focus:

  • Major version upgrades: express-rate-limit (6→8), rate-limit-redis (3→4), rate-limit-memcached (0.6→1.0), commitlint (17→20)
  • Cache mechanism added to avoid "store reuse" error in express-rate-limit v8
  • Removal of custom StoreProvider and in-memory store implementation
  • Type system updates for Redis (redis→ioredis) and new MemcachedClient type definitions

Start review at: src/providers/ratelimit-datasource.provider.ts. This file is critical as it orchestrates the different store implementations (Redis, Memcached, Mongo) and contains the most complex changes around client initialization and type handling with the new package versions.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
48.4% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants