Refactor scip-ruby repo tests and add packaging coverage#252
Draft
jasonhawkharris wants to merge 4 commits into
Draft
Refactor scip-ruby repo tests and add packaging coverage#252jasonhawkharris wants to merge 4 commits into
jasonhawkharris wants to merge 4 commits into
Conversation
c42d303 to
9a2c415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the end-to-end test coverage for scip-ruby by separating repo indexing tests from gem packaging tests.
Repo tests now run the freshly built //main:scip-ruby binary directly against pinned OSS Ruby projects and assert that indexing produces a non-empty SCIP index. This removes the previous Bundler/gem-installation setup, shared bundle cache, repo patches, and disabled CI comments.
This also adds a dedicated packaging test suite that builds a current-platform scip-ruby gem, installs it into a temporary Ruby project through Bundler, runs the installed scip-ruby executable, and verifies that it produces a non-empty SCIP index. The gem build rules now support current-platform test gems.
Docs and CI/Buildkite configuration were updated so repo tests and packaging tests run as separate jobs with clearer ownership and failure modes.
Motivation
The previous repo test setup tried to validate too many things at once: real-project indexing, gem packaging, Bundler installation, Ruby toolchain mutation, dependency caching, and local patching of third-party repos.
That made the tests fragile, hard to run in CI and difficult to debug. A failure could come from the indexer itself, the packaging path, Bundler behavior, cache synchronization, platform-specific patches, or the Ruby environment itself.
Splitting the coverage gives us clearer confidence:
Test plan
See included automated tests:
./bazel test //test/scip/repos --config=dbg./bazel test //test/scip/packaging --config=dbgCI and Buildkite now run the repo and packaging test suites separately.