Skip to content

feat(acp): expose bounded provider retry progress - #335

Merged
danielkov merged 4 commits into
mainfrom
danielkov/feat-45-expose-provider-retry-progress-and-attempt
Nov 1, 2026
Merged

danielkov merged 4 commits into
mainfrom
danielkov/feat-45-expose-provider-retry-progress-and-attempt

Conversation

@danielkov

@danielkov danielkov commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Expose sanitized provider retry progress to ACP v1/v2 clients and live subagent activity, including foreground and background compose execution. Preserve actual provider attempt counts, next delay, and cumulative completed backoff without introducing another model or tool outcome.

Resolves #45.

Technical details

Retry notices carry typed kit/providerRetry metadata containing route, status, attempts, reason category, next delay, and completed backoff milliseconds. Scheduled notices are limited to one per second of provider elapsed time and sixteen per logical request; the final retry observation clears activity and preserves exact accounting even when intermediate observations were suppressed.

ACP v1 emits or forwards this retry stream only when the parent advertises session.notices; nested Kit clients advertise that support. ACP v2 requires no notice capability, as specified by its notice contract.

The projection copies only allowlisted enums and numeric accounting. Provider payloads, prompts, credentials, endpoints, and customer identifiers are not included. Child notices retain their session ownership and are also projected into typed retry activity; centralized UI presentation remains separate.

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retry-notice stream needs to respect the client's negotiated notice capability.

Took 18 min

Comment thread src/protocols/acp.rs Resolved

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new v1 child notice advertisement can forward ordinary notices to parent clients that did not negotiate notice support.

Took 6 min 47 sec

Comment thread src/acp_child/protocol.rs Resolved

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

Took 5 min 19 sec

@danielkov
danielkov merged commit 3603606 into main Nov 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose provider retry progress and attempt counts to ACP parents

1 participant